-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(alpha): support RDF response via http query request (#8004) #8639
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mangalaman93
force-pushed
the
anurag/cp-rdf-over-http
branch
2 times, most recently
from
May 17, 2023 20:43
4f6a4dd
to
10aa259
Compare
mangalaman93
changed the title
Anurag/cp rdf over http
feat(http): Support RDF response via http query request (#8004)
May 17, 2023
mangalaman93
requested review from
akon-dey,
skrdgraph,
darkn3rd,
meghalims,
matthewmcneely and
billprovince
as code owners
May 17, 2023 20:45
mangalaman93
force-pushed
the
anurag/cp-rdf-over-http
branch
2 times, most recently
from
May 17, 2023 20:53
dcea048
to
8c32893
Compare
mangalaman93
force-pushed
the
anurag/cp-rdf-over-http
branch
from
May 31, 2023 04:52
8c32893
to
3da7ce6
Compare
mangalaman93
changed the title
feat(http): Support RDF response via http query request (#8004)
feat(alpha): support RDF response via http query request (#8004)
Jul 28, 2023
mangalaman93
force-pushed
the
anurag/cp-rdf-over-http
branch
from
July 28, 2023 14:56
3da7ce6
to
65ae7c1
Compare
mangalaman93
requested review from
mangalaman93,
sanjayk-github-dev,
harshil-goel and
joshua-goldstein
as code owners
July 28, 2023 14:56
mangalaman93
force-pushed
the
anurag/cp-rdf-over-http
branch
from
July 28, 2023 21:31
65ae7c1
to
7bd4b11
Compare
mangalaman93
previously approved these changes
Jul 28, 2023
sanjayk-github-dev
previously approved these changes
Jul 28, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changes LGTM
MichelDiz
previously approved these changes
Jul 29, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The response looks good
{
"data":"<0x1> <name> \"Bob \\\"\\u003cthe builder\\u003e\\\"\" .\n<0x1> <balance> \"110\" .\n"
}
mangalaman93
dismissed stale reviews from MichelDiz, sanjayk-github-dev, and themself
via
July 29, 2023 04:37
53b43c2
mangalaman93
force-pushed
the
anurag/cp-rdf-over-http
branch
from
July 29, 2023 04:37
7bd4b11
to
53b43c2
Compare
MichelDiz
approved these changes
Jul 30, 2023
sanjayk-github-dev
approved these changes
Jul 31, 2023
jbhamra1
pushed a commit
that referenced
this pull request
Aug 17, 2023
Fixes #8529 Closes: DGRAPHCORE-223 inspired from #8004 Co-authored-by: Aman Mangal <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #8529
Closes: DGRAPHCORE-223
inspired from #8004