fix(backup): create directory before writing backup #8638
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mangalaman93
requested review from
akon-dey,
skrdgraph,
darkn3rd,
meghalims,
matthewmcneely and
billprovince
as code owners
mangalaman93
force-pushed
the
aman/dir
branch
from
2486926 to
5064cd7
Compare
mangalaman93
force-pushed
the
aman/dir
branch
from
5064cd7 to
0879ef9
Compare
harshil-goel
approved these changes
Jan 30, 2023
all-seeing-code
approved these changes
Jan 30, 2023
all-seeing-code
pushed a commit
that referenced
this pull request
Feb 8, 2023
We used to create the directory while creating a backup if one didn't exist. Slash branch doesn't create one but I think we should continue with the behaviour of creating a directory as was there in main branch.
all-seeing-code
pushed a commit
that referenced
this pull request
Feb 8, 2023
We used to create the directory while creating a backup if one didn't exist. Slash branch doesn't create one but I think we should continue with the behaviour of creating a directory as was there in main branch.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We used to create the directory while creating a backup if one didn't exist. Slash branch doesn't create one but I think we should continue with the behaviour of creating a directory as was there in main branch.