Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(linter): address gosimple linter reports & errors #8628

Merged
merged 1 commit into from
Jan 24, 2023
Merged

fix(linter): address gosimple linter reports & errors #8628

merged 1 commit into from
Jan 24, 2023

Conversation

skrdgraph
Copy link
Contributor

@skrdgraph skrdgraph commented Jan 24, 2023 •
edited
Loading

@github-actions github-actions bot added the area/bulk-loader Issues related to bulk loading. label Jan 24, 2023
@skrdgraph skrdgraph marked this pull request as ready for review January 24, 2023 10:18
@skrdgraph
Copy link
Contributor Author

@anurags92 @mangalaman93 @harshil-goel, I have uncommented and fixed 2 linters. We will gradually open up the rest.

mangalaman93
mangalaman93 approved these changes Jan 24, 2023
View reviewed changes
Copy link
Member

@mangalaman93 mangalaman93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a better idea. LGTM

@coveralls
Copy link

Coverage Status

Coverage: 67.046% (+0.1%) from 66.946% when pulling 854f071 on skrdgraph/go-lint-tmp-fixes into 5bbea2f on main.

@all-seeing-code all-seeing-code merged commit 2212e3f into main Jan 24, 2023
@all-seeing-code all-seeing-code deleted the skrdgraph/go-lint-tmp-fixes branch January 24, 2023 11:06
all-seeing-code pushed a commit that referenced this pull request Feb 8, 2023
@skrdgraph @all-seeing-code
fix(linter): address gosimple linter reports & errors (#8628)
7d59d22 
GoLinter failures: 
- related to #8620 &
https://github.com/dgraph-io/dgraph/actions/runs/3971511349/jobs/6815792372
- Addressing this partially
#8572 (comment)
- fix `gosimple` & `unused` linter reports
- comment the rest to address later
@MichelDiz MichelDiz added the dgraph Issue or PR created by an internal Dgraph contributor. label Mar 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@all-seeing-code all-seeing-code all-seeing-code approved these changes

@mangalaman93 mangalaman93 mangalaman93 approved these changes

@akon-dey akon-dey Awaiting requested review from akon-dey

@darkn3rd darkn3rd Awaiting requested review from darkn3rd

@meghalims meghalims Awaiting requested review from meghalims

@matthewmcneely matthewmcneely Awaiting requested review from matthewmcneely

@billprovince billprovince Awaiting requested review from billprovince

Assignees
No one assigned
Labels
area/bulk-loader Issues related to bulk loading. dgraph Issue or PR created by an internal Dgraph contributor.
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@skrdgraph @coveralls @mangalaman93 @all-seeing-code @MichelDiz