feat(cloud): add shared-instance flag in limit superflag in alpha (#7770) #8625
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
all-seeing-code
requested review from
akon-dey,
skrdgraph,
darkn3rd,
meghalims,
matthewmcneely and
billprovince
as code owners
all-seeing-code
added
the
slash-to-main
mangalaman93
requested changes
Feb 2, 2023
all-seeing-code
force-pushed
the
anurag/cp-limit-flag-2
branch
from
10e06cf to
6617b70
Compare
I am not very sure about why do we need this in cloud. @rarvikar could you put some thoughts on this?
I couldn't find a place that pertained to this. I do see a test in |
mangalaman93
requested changes
Feb 8, 2023
|
Hi @anurags92 @mangalaman93 , we use this flag to bypass ACL logins for users of shared backends. This flag IS in-use on all of our regional shared Dgraph clusters hosting shared and free customer backends. |
mangalaman93
previously approved these changes
Feb 8, 2023
all-seeing-code
force-pushed
the
anurag/cp-limit-flag-2
branch
from
c3837f8 to
ccc5d6c
Compare
author Anurag <[email protected]> 1620201646 +0530 committer Anurag <[email protected]> 1675852162 +0530 parent d3bf7b7 author Anurag <[email protected]> 1620201646 +0530 committer Anurag <[email protected]> 1675851671 +0530 feat(cloud): add shared-instance flag in limit superflag in alpha (#7770) This PR adds a shared-instance flag to --limit superflag. When set to true (false by default), it will: - Restrict access to any of the ACL operations like Login, add/remove/update user from non-galaxy namespaces. - Prevent the leaking of environment variables for minio and aws. (cherry picked from commit 5f3cece)
all-seeing-code
force-pushed
the
anurag/cp-limit-flag-2
branch
from
ccc5d6c to
a9616be
Compare
mangalaman93
approved these changes
Feb 8, 2023
harshil-goel
approved these changes
Feb 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a shared-instance flag to --limit superflag.
When set to true (false by default), it will:
(cherry picked from commit 5f3cece)