fix(mutation): validate mutation before applying it #8623
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mangalaman93
requested review from
akon-dey,
skrdgraph,
darkn3rd,
meghalims,
matthewmcneely and
billprovince
as code owners
mangalaman93
force-pushed
the
aman/65k
branch
2 times, most recently
from
89a6bc2 to
f03394b
Compare
mangalaman93
force-pushed
the
aman/65k
branch
from
f03394b to
7c1883e
Compare
mangalaman93
force-pushed
the
aman/65k
branch
from
7c1883e to
5885e5d
Compare
mangalaman93
force-pushed
the
aman/65k
branch
2 times, most recently
from
e5fb320 to
bb0be52
Compare
|
@harshil-goel indexing request comes as part of the Alter request and it is not a transaction. Today, it is acceptable that the indexing could fail. We don't have a good way of letting the user know yet and we should build one. The nice thing here is that the schema remains consistent either way. |
This change ensures that the value in the mutation is not too big. The challenge here is that the keys in badger have a limitation on their size (< 2<<16). We need to ensure that no key, either primary or secondary index, is bigger than that. Fixes dgraph-io/projects-internal#73
all-seeing-code
previously approved these changes
Jan 31, 2023
harshil-goel
previously approved these changes
Jan 31, 2023
mangalaman93
dismissed stale reviews from harshil-goel and all-seeing-code
via
397bac0
mangalaman93
force-pushed
the
aman/65k
branch
from
bb0be52 to
397bac0
Compare
all-seeing-code
approved these changes
Jan 31, 2023
harshil-goel
approved these changes
Jan 31, 2023
all-seeing-code
pushed a commit
that referenced
this pull request
Feb 8, 2023
This change ensures that the value in the mutation is not too big. The challenge here is that the keys in badger have a limitation on their size (< 2<<16). We need to ensure that no key, either primary or secondary index key is bigger than that. Fixes https://github.com/dgraph-io/projects/issues/73
all-seeing-code
pushed a commit
that referenced
this pull request
Feb 8, 2023
This change ensures that the value in the mutation is not too big. The challenge here is that the keys in badger have a limitation on their size (< 2<<16). We need to ensure that no key, either primary or secondary index key is bigger than that. Fixes https://github.com/dgraph-io/projects/issues/73
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change ensures that the value in the mutation is not too big. The challenge here is that the keys in badger have a limitation on their size (< 2<<16). We need to ensure that no key, either primary or secondary index key is bigger than that.
Fixes https://github.com/dgraph-io/projects/issues/73