chore: apply go vet improvements

.golangci.yml

@@ -19,16 +19,16 @@ linters-settings:
 linters:
   disable-all: true
   enable:
-    #- errcheck
-    #- ineffassign
-    #- gas
-    #- gofmt
-    #- golint
-    #- gosimple
-    #- govet
+    - errcheck
+    - ineffassign
+    - gas
+    - gofmt
+    - golint
+    - gosimple
+    - govet
     - lll
-    #- varcheck
-    #- unused
+    - varcheck
+    - unused
 
 issues:
   # Excluding configuration per-path, per-linter, per-text and per-source

compose/compose.go

@@ -245,7 +245,7 @@ func getZero(idx int, raft string) service {
 		svc.Command += fmt.Sprintf(" --vmodule=%s", opts.Vmodule)
 	}
 	if idx == 1 {
-		svc.Command += fmt.Sprintf(" --bindall")
+		svc.Command += " --bindall"
 	} else {
 		svc.Command += fmt.Sprintf(" --peer=%s:%d", name(basename, 1), basePort)
 	}
@@ -734,9 +734,9 @@ func main() {
 
 	doc := fmt.Sprintf("# Auto-generated with: %v\n#\n", os.Args)
 	if opts.UserOwnership {
-		doc += fmt.Sprint("# NOTE: Env var UID must be exported by the shell\n#\n")
+		doc += "# NOTE: Env var UID must be exported by the shell\n#\n"
 	}
-	doc += fmt.Sprintf("%s", yml)
+	doc += string(yml)
 	if opts.OutFile == "-" {
 		x.Check2(fmt.Printf("%s", doc))
 	} else {

contrib/integration/mutates/main.go

@@ -107,7 +107,7 @@ func testInsert3Quads(ctx context.Context, c *dgo.Dgraph) {
 
 func testQuery3Quads(ctx context.Context, c *dgo.Dgraph) {
 	txn := c.NewTxn()
-	q := fmt.Sprint(`{ me(func: uid(200, 300, 400)) { name }}`)
+	q := `{ me(func: uid(200, 300, 400)) { name }}`
 	resp, err := txn.Query(ctx, q)
 	if err != nil {
 		log.Fatalf("Error while running query: %v\n", err)

dgraph/cmd/zero/oracle.go

@@ -34,11 +34,6 @@ import (
 	"github.com/dgraph-io/ristretto/z"
 )
 
-type syncMark struct {
-	index uint64
-	ts    uint64
-}
-
 // Oracle stores and manages the transaction state and conflict detection.
 type Oracle struct {
 	x.SafeMutex

dgraph/cmd/zero/tablet.go

@@ -91,7 +91,7 @@ func (s *Server) MoveTablet(ctx context.Context, req *pb.MoveTabletRequest) (*pb
 	}
 	if !isKnown {
 		return &pb.Status{Code: 1, Msg: x.ErrorInvalidRequest},
-			fmt.Errorf("Group: [%d] is not a known group.", req.DstGroup)
+			fmt.Errorf("group: [%d] is not a known group", req.DstGroup)
 	}
 
 	tablet := x.NamespaceAttr(req.Namespace, req.Tablet)

dgraph/cmd/zero/zero_test.go

@@ -71,7 +71,7 @@ func TestIdBump(t *testing.T) {
 	bumpTo := res.GetEndId() + 100000
 
 	// Bump the lease to (last result + 100000).
-	res, err = zc.AssignIds(ctx, &pb.Num{Val: bumpTo, Type: pb.Num_UID, Bump: true})
+	_, err = zc.AssignIds(ctx, &pb.Num{Val: bumpTo, Type: pb.Num_UID, Bump: true})
 	require.NoError(t, err)
 
 	// Next assignemnt's startId should be greater than bumpTo.
@@ -81,6 +81,6 @@ func TestIdBump(t *testing.T) {
 	require.Equal(t, uint64(10), res.GetEndId()-res.GetStartId()+1)
 
 	// If bump request is less than maxLease, then it should result in no-op.
-	res, err = zc.AssignIds(ctx, &pb.Num{Val: 10, Type: pb.Num_UID, Bump: true})
+	_, err = zc.AssignIds(ctx, &pb.Num{Val: 10, Type: pb.Num_UID, Bump: true})
 	require.Contains(t, err.Error(), "Nothing to be leased")
 }