Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(test): fix the corner case for raft entries test #8617

Merged
merged 1 commit into from
Jan 20, 2023
Merged

Conversation

mangalaman93
Copy link
Member

@mangalaman93 mangalaman93 commented Jan 19, 2023

A failure here: https://github.com/dgraph-io/dgraph/actions/runs/3952517043/jobs/6767694064

This happens when the length of data byte slice is 0. I do not think that is a valid case.

=== RUN   TestEntryReadWrite
    encryption_test.go:48: 
        	Error Trace:	encryption_test.go:48
        	Error:      	Not equal: 
        	            	expected: []byte{}
        	            	actual  : []byte(nil)
        	            	
        	            	Diff:
        	            	--- Expected
        	            	+++ Actual
        	            	@@ -1,3 +1,2 @@
        	            	-([]uint8) {
        	            	-}
        	            	+([]uint8) <nil>
        	            	 
        	Test:       	TestEntryReadWrite
--- FAIL: TestEntryReadWrite (0.02s)
FAIL

Copy link
Contributor

@sanjayk-github-dev sanjayk-github-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@all-seeing-code all-seeing-code self-requested a review January 19, 2023 15:54
@coveralls
Copy link

Coverage Status

Coverage: 66.74% (+0.4%) from 66.375% when pulling f215457 on aman/raft into ee15a9f on main.

Copy link
Contributor

@sanjayk-github-dev sanjayk-github-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mangalaman93 mangalaman93 merged commit 0ba4e26 into main Jan 20, 2023
@mangalaman93 mangalaman93 deleted the aman/raft branch January 20, 2023 07:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants