Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ci): unpin curl #8577

Merged
merged 1 commit into from
Jan 5, 2023
Merged

fix(ci): unpin curl #8577

merged 1 commit into from
Jan 5, 2023

Conversation

skrdgraph
Copy link
Contributor

Problem

there are compatibility issues with base packages and curl package version

Solution

pin to latest

@skrdgraph skrdgraph marked this pull request as ready for review January 5, 2023 22:04
@skrdgraph skrdgraph requested a review from darkn3rd as a code owner January 5, 2023 22:04
@github-actions github-actions bot added the area/integrations Related to integrations with other projects. label Jan 5, 2023
adityasadalage
adityasadalage approved these changes Jan 5, 2023
View reviewed changes
Copy link
Contributor

@adityasadalage adityasadalage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@joshua-goldstein joshua-goldstein self-requested a review January 5, 2023 22:11
joshua-goldstein
joshua-goldstein approved these changes Jan 5, 2023
View reviewed changes
Copy link
Contributor

@joshua-goldstein joshua-goldstein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍 We can look into removing these version pins on other tools in the future

@skrdgraph skrdgraph merged commit 5c77386 into main Jan 5, 2023
@skrdgraph skrdgraph deleted the skrdgraph/unpin_curl branch January 5, 2023 22:12
@coveralls
Copy link

Coverage Status

Coverage: 64.132% (-0.06%) from 64.19% when pulling 8ef7a99 on skrdgraph/unpin_curl into c4a637e on main.

@all-seeing-code
Copy link
Contributor

@skrdgraph unpinning this breaks workflow to build local image (for cloud deployment):
I guessing this could be because I am building ubuntu20.04 base image on ubuntu22.04 and the curl is unable to figure out right dependencies

 make image-local
make[1]: Entering directory '/home/alvis/go/src/github.com/dgraph-io/dgraph'
make -w -C dgraph all
make[2]: Entering directory '/home/alvis/go/src/github.com/dgraph-io/dgraph/dgraph'
make[2]: Leaving directory '/home/alvis/go/src/github.com/dgraph-io/dgraph/dgraph'
make[1]: Leaving directory '/home/alvis/go/src/github.com/dgraph-io/dgraph'
Sending build context to Docker daemon  449.3MB
Step 1/18 : FROM ubuntu:20.04
 ---> 817578334b4d
Step 2/18 : LABEL maintainer="Dgraph Labs <[email protected]>"
 ---> Using cache
 ---> b7d521842518
Step 3/18 : RUN rm -rf /var/lib/apt/lists/*
 ---> Using cache
 ---> 91b1753a0b20
Step 4/18 : RUN apt-get update
 ---> Using cache
 ---> 3a43fc66e1e9
Step 5/18 : RUN apt-get install -y --no-install-recommends ca-certificates="20211016ubuntu0.20.04.1"
 ---> Using cache
 ---> 280907299304
Step 6/18 : RUN apt-get install -y --no-install-recommends curl
 ---> Running in e1fa9647cdac
Reading package lists...
Building dependency tree...
Reading state information...
The following additional packages will be installed:
  libasn1-8-heimdal libbrotli1 libcurl4 libgssapi-krb5-2 libgssapi3-heimdal
  libhcrypto4-heimdal libheimbase1-heimdal libheimntlm0-heimdal
  libhx509-5-heimdal libk5crypto3 libkeyutils1 libkrb5-26-heimdal libkrb5-3
  libkrb5support0 libldap-2.4-2 libldap-common libnghttp2-14 libpsl5
  libroken18-heimdal librtmp1 libsasl2-2 libsasl2-modules-db libsqlite3-0
  libssh-4 libwind0-heimdal
Suggested packages:
  krb5-doc krb5-user
Recommended packages:
  krb5-locales publicsuffix libsasl2-modules
The following NEW packages will be installed:
  curl libasn1-8-heimdal libbrotli1 libcurl4 libgssapi-krb5-2
  libgssapi3-heimdal libhcrypto4-heimdal libheimbase1-heimdal
  libheimntlm0-heimdal libhx509-5-heimdal libk5crypto3 libkeyutils1
  libkrb5-26-heimdal libkrb5-3 libkrb5support0 libldap-2.4-2 libldap-common
  libnghttp2-14 libpsl5 libroken18-heimdal librtmp1 libsasl2-2
  libsasl2-modules-db libsqlite3-0 libssh-4 libwind0-heimdal
0 upgraded, 26 newly installed, 0 to remove and 7 not upgraded.
Need to get 3189 kB of archives.
After this operation, 10.2 MB of additional disk space will be used.
Get:1 http://archive.ubuntu.com/ubuntu focal-updates/main amd64 libsqlite3-0 amd64 3.31.1-4ubuntu0.5 [549 kB]
Get:2 http://archive.ubuntu.com/ubuntu focal-updates/main amd64 libkrb5support0 amd64 1.17-6ubuntu4.1 [30.9 kB]
Get:3 http://archive.ubuntu.com/ubuntu focal-updates/main amd64 libk5crypto3 amd64 1.17-6ubuntu4.1 [79.9 kB]
Get:4 http://archive.ubuntu.com/ubuntu focal-updates/main amd64 libkeyutils1 amd64 1.6-6ubuntu1.1 [10.3 kB]
Get:5 http://archive.ubuntu.com/ubuntu focal-updates/main amd64 libkrb5-3 amd64 1.17-6ubuntu4.1 [330 kB]
Get:6 http://archive.ubuntu.com/ubuntu focal-updates/main amd64 libgssapi-krb5-2 amd64 1.17-6ubuntu4.1 [121 kB]
Get:7 http://archive.ubuntu.com/ubuntu focal/main amd64 libpsl5 amd64 0.21.0-1ubuntu1 [51.5 kB]
Get:8 http://archive.ubuntu.com/ubuntu focal-updates/main amd64 libbrotli1 amd64 1.0.7-6ubuntu0.1 [267 kB]
Ign:9 http://archive.ubuntu.com/ubuntu focal-updates/main amd64 libroken18-heimdal amd64 7.7.0+dfsg-1ubuntu1.2
Ign:10 http://archive.ubuntu.com/ubuntu focal-updates/main amd64 libasn1-8-heimdal amd64 7.7.0+dfsg-1ubuntu1.2
Ign:11 http://archive.ubuntu.com/ubuntu focal-updates/main amd64 libheimbase1-heimdal amd64 7.7.0+dfsg-1ubuntu1.2
Err:9 http://security.ubuntu.com/ubuntu focal-updates/main amd64 libroken18-heimdal amd64 7.7.0+dfsg-1ubuntu1.2
  404  Not Found [IP: 91.189.91.39 80]
Ign:12 http://archive.ubuntu.com/ubuntu focal-updates/main amd64 libhcrypto4-heimdal amd64 7.7.0+dfsg-1ubuntu1.2
Err:10 http://security.ubuntu.com/ubuntu focal-updates/main amd64 libasn1-8-heimdal amd64 7.7.0+dfsg-1ubuntu1.2
  400  Bad Request [IP: 91.189.91.39 80]
Ign:13 http://archive.ubuntu.com/ubuntu focal-updates/main amd64 libwind0-heimdal amd64 7.7.0+dfsg-1ubuntu1.2
Err:11 http://security.ubuntu.com/ubuntu focal-updates/main amd64 libheimbase1-heimdal amd64 7.7.0+dfsg-1ubuntu1.2
  404  Not Found [IP: 91.189.91.39 80]
Ign:14 http://archive.ubuntu.com/ubuntu focal-updates/main amd64 libhx509-5-heimdal amd64 7.7.0+dfsg-1ubuntu1.2
Err:12 http://security.ubuntu.com/ubuntu focal-updates/main amd64 libhcrypto4-heimdal amd64 7.7.0+dfsg-1ubuntu1.2
  404  Not Found [IP: 91.189.91.39 80]
Ign:15 http://archive.ubuntu.com/ubuntu focal-updates/main amd64 libkrb5-26-heimdal amd64 7.7.0+dfsg-1ubuntu1.2
Err:13 http://security.ubuntu.com/ubuntu focal-updates/main amd64 libwind0-heimdal amd64 7.7.0+dfsg-1ubuntu1.2
  404  Not Found [IP: 91.189.91.39 80]
Ign:16 http://archive.ubuntu.com/ubuntu focal-updates/main amd64 libheimntlm0-heimdal amd64 7.7.0+dfsg-1ubuntu1.2
Err:14 http://security.ubuntu.com/ubuntu focal-updates/main amd64 libhx509-5-heimdal amd64 7.7.0+dfsg-1ubuntu1.2
  404  Not Found [IP: 91.189.91.39 80]
Ign:17 http://archive.ubuntu.com/ubuntu focal-updates/main amd64 libgssapi3-heimdal amd64 7.7.0+dfsg-1ubuntu1.2
Err:15 http://security.ubuntu.com/ubuntu focal-updates/main amd64 libkrb5-26-heimdal amd64 7.7.0+dfsg-1ubuntu1.2
  404  Not Found [IP: 91.189.91.39 80]
Get:18 http://archive.ubuntu.com/ubuntu focal-updates/main amd64 libsasl2-modules-db amd64 2.1.27+dfsg-2ubuntu0.1 [14.7 kB]
Err:16 http://security.ubuntu.com/ubuntu focal-updates/main amd64 libheimntlm0-heimdal amd64 7.7.0+dfsg-1ubuntu1.2
  404  Not Found [IP: 91.189.91.39 80]
Ign:19 http://archive.ubuntu.com/ubuntu focal-updates/main amd64 libsasl2-2 amd64 2.1.27+dfsg-2ubuntu0.1
Err:17 http://security.ubuntu.com/ubuntu focal-updates/main amd64 libgssapi3-heimdal amd64 7.7.0+dfsg-1ubuntu1.2
  404  Not Found [IP: 91.189.91.39 80]
Get:20 http://archive.ubuntu.com/ubuntu focal-updates/main amd64 libldap-common all 2.4.49+dfsg-2ubuntu1.9 [16.6 kB]
Get:19 http://security.ubuntu.com/ubuntu focal-updates/main amd64 libsasl2-2 amd64 2.1.27+dfsg-2ubuntu0.1 [49.3 kB]
Get:21 http://archive.ubuntu.com/ubuntu focal-updates/main amd64 libldap-2.4-2 amd64 2.4.49+dfsg-2ubuntu1.9 [155 kB]
Get:22 http://archive.ubuntu.com/ubuntu focal/main amd64 libnghttp2-14 amd64 1.40.0-1build1 [78.7 kB]
Get:23 http://archive.ubuntu.com/ubuntu focal/main amd64 librtmp1 amd64 2.4+20151223.gitfa8646d.1-2build1 [54.9 kB]
Get:24 http://archive.ubuntu.com/ubuntu focal-updates/main amd64 libssh-4 amd64 0.9.3-2ubuntu2.2 [170 kB]
Ign:25 http://archive.ubuntu.com/ubuntu focal-updates/main amd64 libcurl4 amd64 7.68.0-1ubuntu2.14
Ign:26 http://archive.ubuntu.com/ubuntu focal-updates/main amd64 curl amd64 7.68.0-1ubuntu2.14
Err:25 http://security.ubuntu.com/ubuntu focal-updates/main amd64 libcurl4 amd64 7.68.0-1ubuntu2.14
  404  Not Found [IP: 91.189.91.39 80]
Err:26 http://security.ubuntu.com/ubuntu focal-updates/main amd64 curl amd64 7.68.0-1ubuntu2.14
  404  Not Found [IP: 91.189.91.39 80]
Fetched 1978 kB in 5s (396 kB/s)
E: Failed to fetch http://security.ubuntu.com/ubuntu/pool/main/h/heimdal/libroken18-heimdal_7.7.0+dfsg-1ubuntu1.2_amd64.deb  404  Not Found [IP: 91.189.91.39 80]
E: Failed to fetch http://security.ubuntu.com/ubuntu/pool/main/h/heimdal/libasn1-8-heimdal_7.7.0+dfsg-1ubuntu1.2_amd64.deb  400  Bad Request [IP: 91.189.91.39 80]
E: Failed to fetch http://security.ubuntu.com/ubuntu/pool/main/h/heimdal/libheimbase1-heimdal_7.7.0+dfsg-1ubuntu1.2_amd64.deb  404  Not Found [IP: 91.189.91.39 80]
E: Failed to fetch http://security.ubuntu.com/ubuntu/pool/main/h/heimdal/libhcrypto4-heimdal_7.7.0+dfsg-1ubuntu1.2_amd64.deb  404  Not Found [IP: 91.189.91.39 80]
E: Failed to fetch http://security.ubuntu.com/ubuntu/pool/main/h/heimdal/libwind0-heimdal_7.7.0+dfsg-1ubuntu1.2_amd64.deb  404  Not Found [IP: 91.189.91.39 80]
E: Failed to fetch http://security.ubuntu.com/ubuntu/pool/main/h/heimdal/libhx509-5-heimdal_7.7.0+dfsg-1ubuntu1.2_amd64.deb  404  Not Found [IP: 91.189.91.39 80]
E: Failed to fetch http://security.ubuntu.com/ubuntu/pool/main/h/heimdal/libkrb5-26-heimdal_7.7.0+dfsg-1ubuntu1.2_amd64.deb  404  Not Found [IP: 91.189.91.39 80]
E: Failed to fetch http://security.ubuntu.com/ubuntu/pool/main/h/heimdal/libheimntlm0-heimdal_7.7.0+dfsg-1ubuntu1.2_amd64.deb  404  Not Found [IP: 91.189.91.39 80]
E: Failed to fetch http://security.ubuntu.com/ubuntu/pool/main/h/heimdal/libgssapi3-heimdal_7.7.0+dfsg-1ubuntu1.2_amd64.deb  404  Not Found [IP: 91.189.91.39 80]
E: Failed to fetch http://security.ubuntu.com/ubuntu/pool/main/c/curl/libcurl4_7.68.0-1ubuntu2.14_amd64.deb  404  Not Found [IP: 91.189.91.39 80]
E: Failed to fetch http://security.ubuntu.com/ubuntu/pool/main/c/curl/curl_7.68.0-1ubuntu2.14_amd64.deb  404  Not Found [IP: 91.189.91.39 80]
E: Unable to fetch some archives, maybe run apt-get update or try with --fix-missing?
The command '/bin/sh -c apt-get install -y --no-install-recommends curl' returned a non-zero code: 100
make: *** [Makefile:72: image-local] Error 100

@MichelDiz MichelDiz added the dgraph Issue or PR created by an internal Dgraph contributor. label Mar 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joshua-goldstein joshua-goldstein joshua-goldstein approved these changes

@adityasadalage adityasadalage adityasadalage approved these changes

@darkn3rd darkn3rd Awaiting requested review from darkn3rd

Assignees
No one assigned
Labels
area/integrations Related to integrations with other projects. dgraph Issue or PR created by an internal Dgraph contributor.
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@skrdgraph @coveralls @all-seeing-code @adityasadalage @joshua-goldstein @MichelDiz