Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(GraphQL): Pass on HTTP request headers for subscriptions (#7806) (#7807) #8574

Merged
merged 2 commits into from
Jan 5, 2023
Merged

fix(GraphQL): Pass on HTTP request headers for subscriptions (#7806) (#7807) #8574

merged 2 commits into from
Jan 5, 2023

Conversation

all-seeing-code
Copy link
Contributor

@all-seeing-code all-seeing-code commented Jan 4, 2023 •
edited
Loading

Include headers from subscribe request and pass it along the downstream for processing.

Co-authored-by: aman-bansal [email protected]

Co-authored-by: Abhimanyu Singh Gaur [email protected]
(cherry picked from commit dbd5744)

@aman-bansal @all-seeing-code
fix(GraphQL): Pass on HTTP request headers for subscriptions (#7806) (#…
a1d7411 
…7807)

* return as soon as error is encountered

* fix comment

* add more logs

* fixing the http request header to be set in the subscription

* fixing header type cast

Co-authored-by: aman-bansal <[email protected]>

Co-authored-by: Abhimanyu Singh Gaur <[email protected]>
(cherry picked from commit dbd5744)
@CLAassistant
Copy link

CLAassistant commented Jan 4, 2023 •
edited
Loading

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ anurags92
❌ aman-bansal
You have signed the CLA already but the status is still pending? Let us recheck it.

@github-actions github-actions bot added the area/graphql Issues related to GraphQL support on Dgraph. label Jan 4, 2023
@coveralls
Copy link

coveralls commented Jan 4, 2023 •
edited
Loading

Coverage Status

Coverage: 64.492% (+0.1%) from 64.366% when pulling 9402795 on anurag/cp-http-headers into 8c72479 on main.

@mangalaman93 mangalaman93 added the slash-to-main PRs which bring slash branch on par with main. label Jan 5, 2023
@mangalaman93
Copy link
Member

the description of the commit is not accurate, please fix it.

mangalaman93
mangalaman93 requested changes Jan 5, 2023
View reviewed changes
graphql/admin/http.go Outdated Show resolved Hide resolved
mangalaman93
mangalaman93 approved these changes Jan 5, 2023
View reviewed changes
Copy link
Member

@mangalaman93 mangalaman93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please squash & merge

@all-seeing-code all-seeing-code merged commit d3ed882 into main Jan 5, 2023
@all-seeing-code all-seeing-code deleted the anurag/cp-http-headers branch January 5, 2023 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MichelDiz MichelDiz MichelDiz approved these changes

@mangalaman93 mangalaman93 mangalaman93 approved these changes

@akon-dey akon-dey Awaiting requested review from akon-dey

@matthewmcneely matthewmcneely Awaiting requested review from matthewmcneely

Assignees
No one assigned
Labels
area/graphql Issues related to GraphQL support on Dgraph. slash-to-main PRs which bring slash branch on par with main.
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@all-seeing-code @CLAassistant @coveralls @mangalaman93 @MichelDiz @aman-bansal