Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(logs): add logs to track dropped proposals (#8012) #8568

Merged
merged 1 commit into from
Jan 4, 2023
Merged

chore(logs): add logs to track dropped proposals (#8012) #8568

merged 1 commit into from
Jan 4, 2023

Conversation

all-seeing-code
Copy link
Contributor

@all-seeing-code all-seeing-code commented Jan 4, 2023 •
edited
Loading

(cherry picked from commit db841de)

(cherry picked from commit 989c9db)

@NamanJain8 @all-seeing-code
chore(logs): add logs to track dropped proposals (#8012)
67a07a8 
(cherry picked from commit db841de)
(cherry picked from commit 989c9db)
@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@all-seeing-code all-seeing-code marked this pull request as ready for review January 4, 2023 19:22
@all-seeing-code all-seeing-code added the slash-to-main PRs which bring slash branch on par with main. label Jan 4, 2023
skrdgraph
skrdgraph approved these changes Jan 4, 2023
View reviewed changes
Copy link
Contributor

@skrdgraph skrdgraph left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@skrdgraph
Copy link
Contributor

More runners were added - and I have re-ran your tests.

@coveralls
Copy link

Coverage Status

Coverage: 64.222% (-0.2%) from 64.401% when pulling 67a07a8 on anurag/cherry-pick-logs-dropped-proposals into 4c1b575 on main.

@all-seeing-code all-seeing-code merged commit 8c72479 into main Jan 4, 2023
@all-seeing-code all-seeing-code deleted the anurag/cherry-pick-logs-dropped-proposals branch January 4, 2023 20:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skrdgraph skrdgraph skrdgraph approved these changes

@matthewmcneely matthewmcneely matthewmcneely approved these changes

@akon-dey akon-dey Awaiting requested review from akon-dey

@darkn3rd darkn3rd Awaiting requested review from darkn3rd

@meghalims meghalims Awaiting requested review from meghalims

@billprovince billprovince Awaiting requested review from billprovince

Assignees
No one assigned
Labels
slash-to-main PRs which bring slash branch on par with main.
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@all-seeing-code @CLAassistant @skrdgraph @coveralls @matthewmcneely @NamanJain8