-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(cdc): Add superflag to enable TLS without CA or certs (#7946) #8564
Conversation
Does the following changes: * will attempt to connect to Kafka over TLS using the system certs. * add helper function x.TLSBaseConfig. * sets the min TLS version to v1.2 along with the minimum cipher suites.
|
@mangalaman93 @Rajakavitha1 when we update main with new flags, I think we should flag it for doc update etc.? What do you think about that? Should we create a new issue/tag someone here/add a label? |
we will have to do it for all the changes. We can do it once slash and main are more aligned. We will just go through the list once again I guess. |
@meghalims Kafka CDC (and by extension tls with Kafka) is completely uncovered by tests. Maybe a good task for a junior? |
This is introduced in v23.0.0 in PR hypermodeinc/dgraph#8564
This is introduced in v23.0.0 in PR hypermodeinc/dgraph#8564
Does the following changes: