Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cdc): Add superflag to enable TLS without CA or certs (#7946) #8564

Merged
merged 1 commit into from
Jan 17, 2023

Conversation

mangalaman93
Copy link
Member

Does the following changes:

  • will attempt to connect to Kafka over TLS using the system certs.
  • add helper function x.TLSBaseConfig.
  • sets the min TLS version to v1.2 along with the minimum cipher suites.

Does the following changes:
 * will attempt to connect to Kafka over TLS using the system certs.
 * add helper function x.TLSBaseConfig.
 * sets the min TLS version to v1.2 along with the minimum cipher suites.
@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@coveralls
Copy link

Coverage Status

Coverage: 64.349% (-0.05%) from 64.401% when pulling 4ce799f on aman/tls into 4c1b575 on main.

@mangalaman93 mangalaman93 added the slash-to-main PRs which bring slash branch on par with main. label Jan 4, 2023
@all-seeing-code
Copy link
Contributor

@mangalaman93 @Rajakavitha1 when we update main with new flags, I think we should flag it for doc update etc.? What do you think about that? Should we create a new issue/tag someone here/add a label?

@mangalaman93
Copy link
Member Author

we will have to do it for all the changes. We can do it once slash and main are more aligned. We will just go through the list once again I guess.

worker/sink_handler.go Show resolved Hide resolved
worker/sink_handler.go Show resolved Hide resolved
@matthewmcneely
Copy link
Member

@meghalims Kafka CDC (and by extension tls with Kafka) is completely uncovered by tests. Maybe a good task for a junior?

@mangalaman93 mangalaman93 added this to the v23.0.0 milestone Jan 11, 2023
@mangalaman93 mangalaman93 merged commit 2aed52e into main Jan 17, 2023
@mangalaman93 mangalaman93 deleted the aman/tls branch January 17, 2023 12:59
mangalaman93 added a commit to dgraph-io/dgraph-docs that referenced this pull request May 23, 2023
mangalaman93 added a commit to dgraph-io/dgraph-docs that referenced this pull request Jul 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
slash-to-main PRs which bring slash branch on par with main.
Development

Successfully merging this pull request may close these issues.

7 participants