Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(restore): Set kv version to restoreTs for all keys (#7930) #8563

Merged
merged 1 commit into from
Feb 2, 2023
Merged

fix(restore): Set kv version to restoreTs for all keys (#7930) #8563

merged 1 commit into from
Feb 2, 2023

Conversation

mangalaman93
Copy link
Member

@mangalaman93 mangalaman93 commented Jan 4, 2023 •
edited
Loading

The kv version should be set to restore timestamp for rolled-up keys and schema keys as well. It would be inconsistent to write data at different timestamp compared to the timestamp that we use for writing schema keys.

@CLAassistant
Copy link

CLAassistant commented Jan 4, 2023 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@mangalaman93 mangalaman93 added the slash-to-main PRs which bring slash branch on par with main. label Jan 4, 2023
matthewmcneely
matthewmcneely previously approved these changes Jan 5, 2023
View reviewed changes
MichelDiz
MichelDiz previously approved these changes Jan 5, 2023
View reviewed changes
@mangalaman93 mangalaman93 added this to the v23.0.0 milestone Jan 11, 2023
@mangalaman93 mangalaman93 force-pushed the aman/acl branch 3 times, most recently from e200988 to 24e8ae7 Compare January 31, 2023 16:51
Base automatically changed from aman/acl to main February 1, 2023 02:59
@akon-dey akon-dey dismissed stale reviews from MichelDiz and matthewmcneely via b7c2cdd February 1, 2023 02:59
@coveralls
Copy link

coveralls commented Feb 1, 2023 •
edited
Loading

Coverage Status

Coverage: 66.91% (+0.2%) from 66.733% when pulling 7f72777 on aman/restoreTs into 9739415 on main.

@mangalaman93
fix(restore): Set kv version to restoreTs for all keys (#7930)
7f72777 
The kv version should be set to restore timestamp for rolled-up keys
and schema keys as well.
@mangalaman93 mangalaman93 merged commit b100a90 into main Feb 2, 2023
@mangalaman93 mangalaman93 deleted the aman/restoreTs branch February 2, 2023 05:11
all-seeing-code pushed a commit that referenced this pull request Feb 8, 2023
@mangalaman93 @all-seeing-code
fix(restore): Set kv version to restoreTs for all keys (#7930) (#8563)
ff8fe2a 
The kv version should be set to restore timestamp for rolled-up keys and
schema keys as well. It would be inconsistent to write data at different
timestamp compared to the timestamp that we use for writing schema keys.
all-seeing-code pushed a commit that referenced this pull request Feb 8, 2023
@mangalaman93 @all-seeing-code
fix(restore): Set kv version to restoreTs for all keys (#7930) (#8563)
77a9c6a 
The kv version should be set to restore timestamp for rolled-up keys and
schema keys as well. It would be inconsistent to write data at different
timestamp compared to the timestamp that we use for writing schema keys.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@harshil-goel harshil-goel harshil-goel approved these changes

@matthewmcneely matthewmcneely matthewmcneely approved these changes

@MichelDiz MichelDiz MichelDiz left review comments

@akon-dey akon-dey Awaiting requested review from akon-dey

@skrdgraph skrdgraph Awaiting requested review from skrdgraph

@darkn3rd darkn3rd Awaiting requested review from darkn3rd

@meghalims meghalims Awaiting requested review from meghalims

@billprovince billprovince Awaiting requested review from billprovince

Assignees
No one assigned
Labels
slash-to-main PRs which bring slash branch on par with main.
Milestone
v23.0.0
Development

Successfully merging this pull request may close these issues.
6 participants
@mangalaman93 @CLAassistant @coveralls @matthewmcneely @MichelDiz @harshil-goel