fix(groot): do not upsert groot for all namespaces on restart #8561
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mangalaman93
requested review from
akon-dey,
skrdgraph,
darkn3rd,
meghalims,
matthewmcneely and
billprovince
as code owners
|
|
mangalaman93
added
the
slash-to-main
MichelDiz
previously approved these changes
Jan 7, 2023
matthewmcneely
previously approved these changes
Jan 9, 2023
mangalaman93
force-pushed
the
aman/ban
branch
from
355fd43 to
74f15c1
Compare
mangalaman93
force-pushed
the
aman/acl
branch
from
6c3eaae to
ff17dff
Compare
mangalaman93
force-pushed
the
aman/ban
branch
from
74f15c1 to
3690034
Compare
mangalaman93
force-pushed
the
aman/acl
branch
from
ff17dff to
1029af1
Compare
mangalaman93
force-pushed
the
aman/ban
branch
from
3690034 to
bb76697
Compare
mangalaman93
force-pushed
the
aman/acl
branch
from
1029af1 to
12b5ebe
Compare
mangalaman93
force-pushed
the
aman/ban
branch
from
bb76697 to
3049796
Compare
all-seeing-code
dismissed stale reviews from matthewmcneely and MichelDiz
via
12b5ebe
mangalaman93
force-pushed
the
aman/acl
branch
from
12b5ebe to
6b27c14
Compare
harshil-goel
previously approved these changes
Jan 30, 2023
mangalaman93
force-pushed
the
aman/acl
branch
from
6b27c14 to
e200988
Compare
harshil-goel
approved these changes
Jan 31, 2023
all-seeing-code
approved these changes
Jan 31, 2023
Earlier, whenever the alpha starts(or restarts), we were upserting guardian and groot for all the namespaces. This is not actually needed. The change was made in the PR #7759 to fix a bulk loader edge case. This PR fixes that by generating the required RDFs in the bulk loader itself. Essentially, it inserts the ACL RDFs when force loading into non-Galaxy namespace. (cherry picked from commit 6730f10)
mangalaman93
force-pushed
the
aman/acl
branch
from
e200988 to
24e8ae7
Compare
matthewmcneely
approved these changes
Jan 31, 2023
all-seeing-code
pushed a commit
that referenced
this pull request
Feb 8, 2023
Earlier, whenever the alpha starts(or restarts), we were upserting guardian and groot for all the namespaces. This is not actually needed. The change was made in the PR #7759 to fix a bulk loader edge case. This PR fixes that by generating the required RDFs in the bulk loader itself. Essentially, it inserts the ACL RDFs when force loading into non-Galaxy namespace. (cherry picked from commit 6730f10) Co-authored-by: Naman Jain <[email protected]>
all-seeing-code
pushed a commit
that referenced
this pull request
Feb 8, 2023
Earlier, whenever the alpha starts(or restarts), we were upserting guardian and groot for all the namespaces. This is not actually needed. The change was made in the PR #7759 to fix a bulk loader edge case. This PR fixes that by generating the required RDFs in the bulk loader itself. Essentially, it inserts the ACL RDFs when force loading into non-Galaxy namespace. (cherry picked from commit 6730f10) Co-authored-by: Naman Jain <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Earlier, whenever the alpha starts(or restarts), we were upserting guardian and groot for all the namespaces. This is not actually needed. The change was made in the PR #7759 to fix a bulk loader edge case. This PR fixes that by generating the required RDFs in the bulk loader itself. Essentially, it inserts the ACL RDFs when force loading into non-Galaxy namespace.
(cherry picked from commit 6730f10)