Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(debug): Check length of wal entry before parsing #8560

Merged
merged 1 commit into from
Jan 5, 2023
Merged

Conversation

mangalaman93
Copy link
Member

Check for the length of wal entry's data before parsing it for key

Check for the length of wal entry's data before parsing it for key
@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@mangalaman93 mangalaman93 added the slash-to-main PRs which bring slash branch on par with main. label Jan 4, 2023
@coveralls
Copy link

Coverage Status

Coverage: 64.042% (-0.4%) from 64.401% when pulling 4cb7c99 on aman/debug into 4c1b575 on main.

@joshua-goldstein joshua-goldstein self-requested a review January 5, 2023 16:39
Copy link
Contributor

@joshua-goldstein joshua-goldstein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like this is a debug tool and instead of panicking we want to print the key.

Copy link
Contributor

@skrdgraph skrdgraph left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good 👍

@mangalaman93 mangalaman93 merged commit c4a637e into main Jan 5, 2023
@mangalaman93 mangalaman93 deleted the aman/debug branch January 5, 2023 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
slash-to-main PRs which bring slash branch on par with main.
Development

Successfully merging this pull request may close these issues.

6 participants