fix(tests): Added Backup/Restore test for NFS. #8551

shivaji-kharse · 2022-12-23T07:18:50Z

Change: Added new automated tests for backup/restore (full as well as incremental ) on NFS.
Test Scenarios covered:-

Full+Incremental backup on nfs mounted directory
Full+Incremental restore from nfs mounted directory.

CLAassistant · 2022-12-23T07:28:44Z

All committers have signed the CLA.

skrdgraph · 2022-12-23T07:51:31Z

this is a draft PR, things done:

GH environment added
enabled GH Runner changes to support this PR

ToDo:

we also have to clean this PR up & rename the env references correctly

Future Changes needed:

move to mock library*
handle bucket lifecycle in this PR*

This PR should NOT be merged till we do some more cleanups.

skrdgraph · 2022-12-23T08:08:58Z

@shivaji-dgraph will fix up the ci-yaml file - because there are py dependencies and other dependencies as you had shown during the call. So once you fix those up, this PR tests should all pass. Post a successful run, we shall start looking into the todo / future comment I posted above.

coveralls · 2022-12-24T06:04:06Z

Coverage: 66.875% (-0.2%) from 67.029% when pulling ae7acdd on backup-systest into c175edc on main.

mangalaman93

These are some really useful tests but we need to improve the tests. I have added a few comments and I can help more if you get stuck. Please take a look.

systest/backup/nfs-backup/docker-compose.yml

systest/backup/nfs-backup/docker-utils/dgraph-nfs-client/Dockerfile

mangalaman93 · 2023-01-06T14:25:30Z

Please rebase the change on latest main and force push before we can review it. Thanks

contrib/Dockerfile

systest/backup/nfs-backup/backup_test.go

contrib/gh-runner/gh-runner.sh

systest/backup/nfs-backup/backup_test.go

systest/backup/nfs-backup/docker-compose.yml

go.mod

go.sum

systest/backup/nfs-backup/backup_test.go

systest/backup/nfs-backup/docker-compose.yml

testutil/client.go

all-seeing-code

Please update the description with information on what scenario is being tested.

systest/backup/nfs-backup/backup_test.go

all-seeing-code · 2023-01-12T09:32:10Z

Change: Added new automated tests for backup/restore (full as well as incremental ) on NFS.

This needs more details.

contrib/gh-runner/gh-runner.sh

systest/backup/nfs-backup/docker-compose.yml

…age and resolved review comments

This reverts commit 9739415. It is failing on CI.

Change: Added new automated tests for backup/restore (full as well as incremental ) on NFS. Test Scenarios covered:- - Full+Incremental backup on nfs mounted directory - Full+Incremental restore from nfs mounted directory.

shivaji-kharse requested review from skrdgraph, darkn3rd, akon-dey, meghalims, matthewmcneely and billprovince as code owners December 23, 2022 07:18

github-actions bot added area/integrations Related to integrations with other projects. area/live-loader Issues related to live loading. area/testing Testing related issues labels Dec 23, 2022

skrdgraph changed the title ~~chore: Added Backup/Restore test for NFS and S3 (Full as well as Incr…~~ fix(tests): Added Backup/Restore test for NFS and S3 Dec 23, 2022

skrdgraph marked this pull request as draft December 23, 2022 08:16

skrdgraph marked this pull request as ready for review December 23, 2022 08:17

mangalaman93 requested changes Jan 3, 2023

View reviewed changes

nswamy self-requested a review January 3, 2023 14:15

shivaji-kharse requested a review from MichelDiz as a code owner January 6, 2023 13:14

shivaji-kharse force-pushed the backup-systest branch 2 times, most recently from e8bc42f to 561ca0c Compare January 10, 2023 10:59

shivaji-kharse changed the title ~~fix(tests): Added Backup/Restore test for NFS and S3~~ fix(tests): Added Backup/Restore test for NFS. Jan 10, 2023

mangalaman93 requested changes Jan 11, 2023

View reviewed changes

mangalaman93 requested changes Jan 12, 2023

View reviewed changes

go.mod Outdated Show resolved Hide resolved

go.sum Outdated Show resolved Hide resolved

systest/backup/nfs-backup/backup_test.go Outdated Show resolved Hide resolved

systest/backup/nfs-backup/docker-compose.yml Show resolved Hide resolved

testutil/client.go Outdated Show resolved Hide resolved

shivaji-kharse force-pushed the backup-systest branch from b2b758d to 09aa050 Compare January 12, 2023 07:02

all-seeing-code reviewed Jan 12, 2023

View reviewed changes

mangalaman93 reviewed Jan 16, 2023

View reviewed changes

contrib/gh-runner/gh-runner.sh Outdated Show resolved Hide resolved

systest/backup/nfs-backup/docker-compose.yml Outdated Show resolved Hide resolved

all-seeing-code previously approved these changes Jan 16, 2023

View reviewed changes

shivaji-kharse added 19 commits January 31, 2023 10:12

Added code to clean up backup destination

f0f97ca

Added test.sh file to debug

e6d3017

Resolved review comments

2bc2245

Resolved review comments

499ba03

Removed unnecessary changes

27e5b20

Added architecture specific enviroment variable to pick nfs server im…

e790d3c

…age and resolved review comments

Resolved review comments

1ba2205

Resolved review comments

1386e19

Resolved review comments

d7b8fab

Added code to create backup directories

cd14069

Resolved review comments

0168492

Fixed backup directory creation code

a6d4e01

fixed backup directories creation and listbackup bug

080baae

Removed unwanted print statments

a2d8d0d

Undid changes

574ba0b

Called WaitForTask function with all arguments

127b01c

Fixed listbackup code

0e09b8b

Removed added code from worker package

a890d46

Resolved review comments

a0cde5a

shivaji-kharse force-pushed the backup-systest branch from 9ba24ef to a0cde5a Compare January 31, 2023 04:43

Resolved review comments

5193511

mangalaman93 approved these changes Jan 31, 2023

View reviewed changes

matthewmcneely approved these changes Jan 31, 2023

View reviewed changes

Merge branch 'main' into backup-systest

ae7acdd

all-seeing-code approved these changes Feb 1, 2023

View reviewed changes

shivaji-kharse merged commit 9739415 into main Feb 1, 2023

shivaji-kharse deleted the backup-systest branch February 1, 2023 17:12

mangalaman93 added a commit that referenced this pull request Feb 6, 2023

Revert "fix(tests): Added Backup/Restore test for NFS. (#8551)"

6e2692a

This reverts commit 9739415. It is failing on CI.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(tests): Added Backup/Restore test for NFS. #8551

fix(tests): Added Backup/Restore test for NFS. #8551

shivaji-kharse commented Dec 23, 2022 •

edited by all-seeing-code

Loading

CLAassistant commented Dec 23, 2022 •

edited

Loading

skrdgraph commented Dec 23, 2022 •

edited

Loading

skrdgraph commented Dec 23, 2022

coveralls commented Dec 24, 2022 •

edited

Loading

mangalaman93 left a comment

mangalaman93 commented Jan 6, 2023

all-seeing-code left a comment

all-seeing-code commented Jan 12, 2023

fix(tests): Added Backup/Restore test for NFS. #8551

fix(tests): Added Backup/Restore test for NFS. #8551

Conversation

shivaji-kharse commented Dec 23, 2022 • edited by all-seeing-code Loading

CLAassistant commented Dec 23, 2022 • edited Loading

skrdgraph commented Dec 23, 2022 • edited Loading

skrdgraph commented Dec 23, 2022

coveralls commented Dec 24, 2022 • edited Loading

mangalaman93 left a comment

Choose a reason for hiding this comment

mangalaman93 commented Jan 6, 2023

all-seeing-code left a comment

Choose a reason for hiding this comment

all-seeing-code commented Jan 12, 2023

shivaji-kharse commented Dec 23, 2022 •

edited by all-seeing-code

Loading

CLAassistant commented Dec 23, 2022 •

edited

Loading

skrdgraph commented Dec 23, 2022 •

edited

Loading

coveralls commented Dec 24, 2022 •

edited

Loading