Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(chore): Add more logging for cloud instances #8507

Merged
merged 2 commits into from
Dec 21, 2022
Merged

fix(chore): Add more logging for cloud instances #8507

merged 2 commits into from
Dec 21, 2022

Conversation

all-seeing-code
Copy link
Contributor

@all-seeing-code all-seeing-code commented Dec 12, 2022 •
edited
Loading

Two cherry-picks

  1. (cherry picked from commit 1e06e81)

  2. (cherry picked from commit bc5f584)

all-seeing-code and others added 2 commits December 12, 2022 15:28
@all-seeing-code
chore(logging): Add more logging and trace tags for debugging (#8490)
90515aa 
Adds logging and sets query `tag` for improved tracing in Jaeger.

Co-authored-by: Damon Feldman <[email protected]>
(cherry picked from commit 1e06e81)
@MichelDiz @all-seeing-code
refactor(GraphQL): Rename logRequest name and its resolver. (#8388)
bcb617a 
In order to add GraphQL Query Log(#8305) we need to rename the current
DQL query log resolver and config.

> Rename: logRequest => logDQLRequest

Important change:

```diff
--- glog.Infof("Got a query: %+v", req.req)
+++ glog.Infof("Got a DQL query: %+v", req.req)
```

(cherry picked from commit bc5f584)
@github-actions github-actions bot added area/documentation Documentation related issues. area/graphql Issues related to GraphQL support on Dgraph. labels Dec 12, 2022
@all-seeing-code all-seeing-code changed the title Anurag/cherry-pick-logging fix(chore): Add more logging for cloud instances Dec 12, 2022
meghalims
meghalims approved these changes Dec 20, 2022
View reviewed changes
Copy link
Contributor

@meghalims meghalims left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@all-seeing-code all-seeing-code merged commit dc32d85 into release/v21.03-slash Dec 21, 2022
@all-seeing-code all-seeing-code deleted the anurag/cherry-pick-logging branch December 21, 2022 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@meghalims meghalims meghalims approved these changes

@mangalaman93 mangalaman93 mangalaman93 approved these changes

@skrdgraph skrdgraph Awaiting requested review from skrdgraph

Assignees
No one assigned
Labels
area/documentation Documentation related issues. area/graphql Issues related to GraphQL support on Dgraph.
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@all-seeing-code @mangalaman93 @meghalims @MichelDiz