Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add intersection tests for linear and binary methods #8488

Merged
merged 2 commits into from
Dec 7, 2022
Merged

Add intersection tests for linear and binary methods #8488

merged 2 commits into from
Dec 7, 2022

Conversation

all-seeing-code
Copy link
Contributor

@all-seeing-code all-seeing-code commented Dec 5, 2022 •
edited
Loading

Add test cases for IntersectWithLin, IntersectWithJump and IntersectWithBin

@all-seeing-code all-seeing-code marked this pull request as ready for review December 5, 2022 20:08
@coveralls
Copy link

Coverage Status

Coverage increased (+0.1%) to 37.293% when pulling 9736215 on anurag/uidlist-test into 2b1441d on main.

meghalims
meghalims approved these changes Dec 7, 2022
View reviewed changes
Copy link
Contributor

@meghalims meghalims left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@all-seeing-code all-seeing-code merged commit 9312d4a into main Dec 7, 2022
@all-seeing-code all-seeing-code deleted the anurag/uidlist-test branch December 7, 2022 19:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nswamy nswamy nswamy left review comments

@meghalims meghalims meghalims approved these changes

@matthewmcneely matthewmcneely matthewmcneely approved these changes

@akon-dey akon-dey Awaiting requested review from akon-dey

@gcxml gcxml Awaiting requested review from gcxml

@skrdgraph skrdgraph Awaiting requested review from skrdgraph

@darkn3rd darkn3rd Awaiting requested review from darkn3rd

@billprovince billprovince Awaiting requested review from billprovince

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@all-seeing-code @coveralls @nswamy @matthewmcneely @meghalims