Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(ci): Capture coverage from bulk load and LDBC tests #8478

Merged
merged 5 commits into from
Jan 10, 2023
Merged

chore(ci): Capture coverage from bulk load and LDBC tests #8478

merged 5 commits into from
Jan 10, 2023

Conversation

all-seeing-code
Copy link
Contributor

@all-seeing-code all-seeing-code commented Dec 5, 2022 •
edited
Loading

Add code coverage for LDBC tests.

Previously I had verified that:

  • LDBC doesn't update code coverage because the query package is well-tested.
  • IC5 times out on test-coverage-binary
    Therefore, I had not enabled the ldbc test suite on code-coverage workflow.

Following @gajanan-dgraph 's prompt I gave this old PR another lookover and found a way to capture code-coverage from bulkload process. I also skip IC05 in LDBC tests.

@github-actions github-actions bot added area/graphql Issues related to GraphQL support on Dgraph. area/integrations Related to integrations with other projects. area/testing Testing related issues labels Dec 5, 2022
@coveralls
Copy link

coveralls commented Dec 5, 2022 •
edited
Loading

Coverage Status

Coverage: 66.671% (+2.4%) from 64.24% when pulling 0ac9f02 on anurag/ldbc-coverage into 9e4b288 on main.

@all-seeing-code all-seeing-code marked this pull request as ready for review January 9, 2023 14:49
@all-seeing-code all-seeing-code changed the title WIP: This PR builds introduces LDBC tests with coverage turned on chore(ci): Capture coverage from bulk load and LDBC tests Jan 9, 2023
@all-seeing-code all-seeing-code merged commit 3dd74d1 into main Jan 10, 2023
@all-seeing-code all-seeing-code deleted the anurag/ldbc-coverage branch January 10, 2023 10:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MichelDiz MichelDiz MichelDiz approved these changes

@mangalaman93 mangalaman93 mangalaman93 approved these changes

@matthewmcneely matthewmcneely matthewmcneely approved these changes

@akon-dey akon-dey Awaiting requested review from akon-dey

@skrdgraph skrdgraph Awaiting requested review from skrdgraph

@darkn3rd darkn3rd Awaiting requested review from darkn3rd

@meghalims meghalims Awaiting requested review from meghalims

@billprovince billprovince Awaiting requested review from billprovince

Assignees
No one assigned
Labels
area/graphql Issues related to GraphQL support on Dgraph. area/integrations Related to integrations with other projects. area/testing Testing related issues
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@all-seeing-code @coveralls @matthewmcneely @mangalaman93 @MichelDiz