Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix(GraphQL): Make mutation rewriting tests more robust (#7768) #8449

Merged
merged 2 commits into from
Nov 29, 2022
Merged

Fix(GraphQL): Make mutation rewriting tests more robust (#7768) #8449

merged 2 commits into from
Nov 29, 2022

Conversation

all-seeing-code
Copy link
Contributor

@all-seeing-code all-seeing-code commented Nov 22, 2022 •
edited
Loading

@vmrajas @all-seeing-code
Fix(GraphQL): Make mutation rewriting tests more robust (#7768)
a07ae32 
* Make mutation rewriting tests more robust

* Fix lint
@all-seeing-code all-seeing-code added the cherry-pick-22.0.2 Label for all cherry-picks for 22.0.2 Release label Nov 22, 2022
@github-actions github-actions bot added the area/graphql Issues related to GraphQL support on Dgraph. label Nov 22, 2022
@coveralls
Copy link

coveralls commented Nov 22, 2022 •
edited
Loading

Coverage Status

Coverage decreased (-0.0003%) to 37.182% when pulling 2f8fe39 on cherry-pick-7768 into b975b98 on main.

MichelDiz
MichelDiz approved these changes Nov 22, 2022
View reviewed changes
Copy link
Contributor

@MichelDiz MichelDiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally, no issues found.

@meghalims meghalims self-requested a review November 29, 2022 19:32
meghalims
meghalims approved these changes Nov 29, 2022
View reviewed changes
Copy link
Contributor

@meghalims meghalims left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The fixes look good.

@meghalims meghalims merged commit 7d7c02f into main Nov 29, 2022
@meghalims meghalims deleted the cherry-pick-7768 branch November 29, 2022 21:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@meghalims meghalims meghalims approved these changes

@MichelDiz MichelDiz MichelDiz approved these changes

@matthewmcneely matthewmcneely matthewmcneely approved these changes

@akon-dey akon-dey Awaiting requested review from akon-dey

@billprovince billprovince Awaiting requested review from billprovince

Assignees
No one assigned
Labels
area/graphql Issues related to GraphQL support on Dgraph. cherry-pick-22.0.2 Label for all cherry-picks for 22.0.2 Release
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@all-seeing-code @coveralls @matthewmcneely @MichelDiz @meghalims @vmrajas