-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(admin): make config changes to pass through gog middlewares (#8014) #8442
Conversation
Currently, guardians of any namespace can enable/disable query logging, update the cache parameters, etc. This operation should only be allowed to the guardian of the galaxy. (cherry picked from commit 6737dfd)
|
@joshua-goldstein Please, sign the CLA. FYI. Yes, we need getLambdaScript 100%. It is used in the cloud. If you remove it it will break the entire cloud. |
@MichelDiz I have already signed the CLA, it is giving this message because this is a cherry pick from other commits that have other contributors. To your main point: this is currently not in the main branch. See here. Presumably if we want to base the cloud on v22.0.1 we will have to bring in other changes not related to this PR. |
I see, yep they have changed a lot of places #7955 In 21.03 (and previous versions) we stored the lambda scripts directly via flag in the binary. This change to GraphQL makes easy to deal with the JSscript(it is stored in bas64). This seemed obvious to me. It's a change from 16 months ago. I assumed it was already in effect. As you can see, it is present in v21.09-slash(a cloud version) https://github.com/dgraph-io/dgraph/blob/release/v21.09-slash/graphql/admin/admin.go |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Please merge this Josh
Cherry pick from #8014
In #7955 the team made a change to the way lambda scripts were loaded into Dgraph. This PR had a small conflict with that PR. Any change related to #7955 should be made in another PR.