chore(ci): fix arm workflows + minor CI cleanup #8436
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
area/integrations
joshua-goldstein
requested review from
akon-dey,
gcxml,
skrdgraph,
darkn3rd and
meghalims
as code owners
skrdgraph
reviewed
Nov 16, 2022
| # go env settings | ||
| export GOPATH=~/go | ||
| # move the binary | ||
| cp dgraph/dgraph ~/go/bin | ||
| # build the test binary | ||
| cd t; go build . |
There was a problem hiding this comment.
the go build . is needed right?
There was a problem hiding this comment.
We are calling it in the previous step (around line 50)
joshua-goldstein
requested review from
matthewmcneely and
billprovince
as code owners
|
@joshua-goldstein you need 2 +1's because of the perm changes. @meghalims / @matthewmcneely - could one of you do a quick review? This is quite straightforward IMO. |
matthewmcneely
approved these changes
Nov 18, 2022
joshua-goldstein
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Arm tests were failing because skip list was not being parsed correctly by t.go. We also perform some cleanup on the CI workflows (there was some redundancy in CI scripts).
Solution
We pass
as an argument to t.go. Failures in these packages are related to minio and lambda which we will work on resolving. We also do some cleanup on the workflow file.