-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(fragment): merge the nested fragments fields (#8075) #8435
Conversation
|
Have tested locally, fix works. Need to add unit test case still |
@dshekhar95 Do you have a test proof? that I can run in my end. Looks like you have fixed and send it to the user PoolShark correct? So his example could be a test. BTW, can you sign the CLA? |
This one definitely needs tests. |
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks for adding test. Please go ahead and merge it
Note this fixes a bug where a fragment is used in a query but data is not returned as required by the GraphQL spec. (See discuss link above for details) |
cherry-pick from #8075
Fixes https://discuss.dgraph.io/t/graphql-field-collection-does-not-work-with-dgraph/15646