fix(test): Clean cruft from test run #8348
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skrdgraph
requested review from
akon-dey,
gcxml,
skrdgraph,
darkn3rd and
meghalims
as code owners
skrdgraph
previously approved these changes
Oct 4, 2022
joshua-goldstein
force-pushed
the
main
branch
from
e1d674f to
a80c643
Compare
skrdgraph
reviewed
Oct 17, 2022
edgraph/server_test.go
Outdated
| @@ -204,4 +204,7 @@ func TestParseSchemaFromAlterOperation(t *testing.T) { | |||
| }) | |||
| } | |||
|
|
|||
| ps.Close() | |||
| os.RemoveAll(dir) | |||
There was a problem hiding this comment.
There was a problem hiding this comment.
@skrdgraph Thanks for noticing this, I think now it is much cleaner. Note that defer statements are executed in FILO order.
|
Pushing this out to next release (marking draft temporarily) |
joshua-goldstein
force-pushed
the
joshua/cleaning-test-cherry-8319
branch
from
dd18b4a to
6e8d4cb
Compare
joshua-goldstein
requested review from
matthewmcneely and
billprovince
as code owners
mangalaman93
approved these changes
Feb 21, 2023
all-seeing-code
approved these changes
Mar 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
This PR introduces some badger instances that are not closed.
Solution
We clean up the files.