Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(GraphQL): add validation of null values with correct order of graphql rule validation #8333

Merged
merged 6 commits into from
Sep 29, 2022

Conversation

skrdgraph
Copy link
Contributor

the previous merge was not squashed, this was the original PR #8320

… validation (#8007)

  • fix: add validation of null values with correct order of graphql rule validation

Problem

Solution

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ dshekhar95
❌ aman-bansal
You have signed the CLA already but the status is still pending? Let us recheck it.

@skrdgraph skrdgraph marked this pull request as ready for review September 29, 2022 17:21
@skrdgraph skrdgraph changed the title fix: add validation of null values with correct order of graphql rule validation fix(GraphQL): add validation of null values with correct order of graphql rule validation Sep 29, 2022
@dshekhar95 dshekhar95 self-requested a review September 29, 2022 17:26
@joshua-goldstein joshua-goldstein requested review from joshua-goldstein and removed request for dshekhar95 September 29, 2022 17:26
Copy link
Contributor

@joshua-goldstein joshua-goldstein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@dshekhar95 dshekhar95 merged commit 0389683 into main Sep 29, 2022
@dshekhar95 dshekhar95 deleted the cherry-pick-8008_new branch September 29, 2022 17:35
@coveralls
Copy link

Coverage Status

Coverage increased (+0.005%) to 37.107% when pulling 4f1d491 on cherry-pick-8008_new into a2babb8 on main.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

6 participants