Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(query): Prevent multiple entries for same predicate in mutations. #7715 #8332

Merged
merged 2 commits into from
Sep 29, 2022

Conversation

skrdgraph
Copy link
Contributor

we had NOT squashed & merged this #8319

So fixing it up here

Problem

Multiple entries for the same predicate can lead to inconsistent state,

Solution

hence adding an error for it instead.

Fixes DGRAPH-3225

rohanprasad and others added 2 commits September 19, 2022 15:48
…a mutations. (#7715)

* fix(query): Prevent multiple entries for the same predicate/type in mutations.

Fixes DGRAPH-3225
@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ dshekhar95
❌ rohanprasad
You have signed the CLA already but the status is still pending? Let us recheck it.

@skrdgraph skrdgraph marked this pull request as ready for review September 29, 2022 17:18
@joshua-goldstein joshua-goldstein self-requested a review September 29, 2022 17:26
@dshekhar95 dshekhar95 self-requested a review September 29, 2022 17:26
Copy link
Contributor

@joshua-goldstein joshua-goldstein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@dshekhar95 dshekhar95 merged commit fcc8f3e into main Sep 29, 2022
@dshekhar95 dshekhar95 deleted the cherry-pick-7715_new2 branch September 29, 2022 17:35
@coveralls
Copy link

Coverage Status

Coverage increased (+0.06%) to 37.165% when pulling 882d6bf on cherry-pick-7715_new2 into a2babb8 on main.

@joshua-goldstein joshua-goldstein changed the title fix(query): Prevent multiple entries for same predicate in mutations.2022 fix(query): Prevent multiple entries for same predicate in mutations. #7715 Nov 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

6 participants