fix(sec) CVE High Vulnerability #8277
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
skrdgraph
changed the title
skrdgraph
requested review from
akon-dey,
gcxml,
darkn3rd and
meghalims
as code owners
|
There were quite a few merge conflicts ... so had to reopen another branch for this #8265 |
dshekhar95
pushed a commit
that referenced
this pull request
Sep 19, 2022
* fixing CVE-2021-43565 * fixing CVE-2022-27664 * fixing CVE-2022-27191 * fixing CVE-2018-16886 * fixing CVE-2022-21698
skrdgraph
changed the title
joshua-goldstein
added a commit
that referenced
this pull request
Dec 14, 2022
## Problem
Currently our CI runs against main. We would like to run CI against our
slash branch also.
## Solution
In order for CI to run on release/v21.03-slash we must bring over all
the latest changes we made to our main branch. This is work going back a
few months, hence the large number of changes. Going forward we should
keep CI/CD related changes on release branches and main in harmony.
## Steps:
```
git checkout release/v21.03-slash
git checkout main -- Makefile
git checkout main -- dgraph/Makefile
git checkout main -- .github
git checkout main -- .go-version
git checkout main -- t
git checkout main -- tlstest/mtls_internal/tls
git checkout main -- graphql/e2e/custom_logic/cmd/Dockerfile
git checkout main -- systest/ldbc
git rm .github/workflows/{main.yml,golanglintci-lint.yml,label.yml}
```
Bring in coverage changes from #8494 in testutil/{docker.go,bulk.go},
bring in updated dockercompose files (with coverage variable), and
coverage entrypoint
## Todo
#8277
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
As we are nearing cherry-pick process, there have been some CVE reports on our core repo. These CVEs are not critical (luckily). The assumption we had was that these CVEs are at linux layer as opposed to our go pkg layer. This assumption led to an attempt to fix it up by upgrading docker linux layer in this PR #8238 by @darkn3rd (which will not fix our errors & this PR should be closed) . There were 2 issues here:
Solution
I am addressing HIGH & some MEDIUMs/LOWs.
In this I am fixing the following vulnerabilities:
fyi @matthewmcneely @darkn3rd