Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

opening up whitelist for local setup with docker-compose #8139

Merged
merged 5 commits into from
Jun 30, 2022

Conversation

skrdgraph
Copy link
Contributor

@skrdgraph skrdgraph commented Jun 27, 2022

Issue & Fix (in PR)

The existing docker-compose files cause the following errors when trying to interact with dgraphDB:

Sudhishs-MacBook-Pro:Desktop sudhishkr$ curl -X POST localhost:8080/admin/schema --data-binary '@schema.graphql'
{"errors":[{"message":"resolving updateGQLSchema failed because unauthorized ip address: 172.18.0.1 (Locations: [{Line: 3, Column: 4}])","extensions":{"code":"Error"}}]}

The issue here is unauthorized ip address, caused because of whitelist settings. The fix is listed in the article here. The default dgraphDB setting to 127.0.0.1 creates the above problem - and this fix should help ease spinning up the setup locally.

Why is this needed?

  • to Test local execution without minikube or k8s by directly running on top of docker-compose
  • this helps local testing

@skrdgraph skrdgraph added the platform/macos Issue specific to macOS label Jun 27, 2022
@skrdgraph skrdgraph requested review from akon-dey and darkn3rd June 27, 2022 19:03
@CLAassistant
Copy link

CLAassistant commented Jun 27, 2022

CLA assistant check
All committers have signed the CLA.

@github-actions github-actions bot added the area/integrations Related to integrations with other projects. label Jun 27, 2022
@skrdgraph
Copy link
Contributor Author

skrdgraph commented Jun 27, 2022

Looks to be working better now on local environment:

Sudhishs-MacBook-Pro:Desktop sudhishkr$ curl -X POST localhost:8080/admin/schema --data-binary '@schema.graphql'
{"data":{"code":"Success","message":"Done"}}

@darkn3rd ^ - it's now locked to private cidrs

@skrdgraph
Copy link
Contributor Author

@akon-dey could we get this in? there is a separate PR for tests which is being worked on, and the docker-compose changes will not affect any CI / tests as it stands.

@akon-dey akon-dey merged commit 7597cd4 into master Jun 30, 2022
@joshua-goldstein joshua-goldstein deleted the fix/local_docker_compose branch August 18, 2022 23:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/integrations Related to integrations with other projects. platform/macos Issue specific to macOS
Development

Successfully merging this pull request may close these issues.

4 participants