fix(restore-test): Use separate map directory for each group in offline restore #8047
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danielmai
approved these changes
Sep 21, 2021
There was a problem hiding this comment.
Reviewed 3 of 3 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @ahsanbarkati and @manishrjain)
dgraph/cmd/debug/run.go, line 883 at r1 (raw file):
WithBlockCacheSize(1 << 30). WithIndexCacheSize(1 << 30). WithExternalMagic(opt.magic).
Is setting the ExternalMagic option needed in the debug tool now? This is just reading whatever the existing magic version is on disk, righT?
|
dgraph/cmd/debug/run.go, line 883 at r1 (raw file): Previously, danielmai (Daniel Mai) wrote…
Yeah. It is used for verification purposes only. |
mangalaman93
pushed a commit
that referenced
this pull request
Aug 25, 2023
mangalaman93
added a commit
that referenced
this pull request
Aug 25, 2023
mangalaman93
added a commit
that referenced
this pull request
Aug 25, 2023
mangalaman93
added a commit
that referenced
this pull request
Aug 25, 2023
shivaji-kharse
pushed a commit
that referenced
this pull request
Mar 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Offline restore was using the same map directory for all the groups. This causes the same map files to get reduced in multiple groups.
This change is