Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(lambda): make lambda active only after successful start #8036

Merged
merged 1 commit into from
Sep 20, 2021

Conversation

NamanJain8
Copy link
Contributor

@NamanJain8 NamanJain8 commented Sep 17, 2021

There is a logical race condition that causes panic. This happens because the node process did not complete its initialization before being killed. This PR fixes that issue.

This PR also increases the default restart timeout from 10s to 30s to make it more generous.

panic: runtime error: invalid memory address or nil pointer dereference
[signal SIGSEGV: segmentation violation code=0x1 addr=0x0 pc=0xbf5f7b]

goroutine 175 [running]:
os.(*Process).signal(0x0, 0x279b908, 0x32592d8, 0x0, 0x0)
	/usr/local/go/src/os/exec_unix.go:63 +0x3b
os.(*Process).Signal(...)
	/usr/local/go/src/os/exec.go:135
os.(*Process).kill(...)
	/usr/local/go/src/os/exec_posix.go:66
os.(*Process).Kill(...)
	/usr/local/go/src/os/exec.go:120
github.com/dgraph-io/dgraph/dgraph/cmd/alpha.setupLambdaServer.func2(0xc0003be1c0)
	/data/go/src/github.com/dgraph-io/dgraph/dgraph/cmd/alpha/run.go:556 +0x191
github.com/dgraph-io/dgraph/dgraph/cmd/alpha.setupLambdaServer.func3(0xc000118ae0, 0xc0005020a8, 0xc0000df6b0)
	/data/go/src/github.com/dgraph-io/dgraph/dgraph/cmd/alpha/run.go:577 +0x91
created by github.com/dgraph-io/dgraph/dgraph/cmd/alpha.setupLambdaServer
	/data/go/src/github.com/dgraph-io/dgraph/dgraph/cmd/alpha/run.go:568 +0x82b


This change is Reviewable

@NamanJain8 NamanJain8 merged commit eaee2db into master Sep 20, 2021
@NamanJain8 NamanJain8 deleted the naman/lambda-panic branch September 20, 2021 07:48
NamanJain8 added a commit that referenced this pull request Sep 21, 2021
There is a logical race condition that causes panic. This happens because the node process did not complete its initialization before being killed. This PR fixes that issue.

This PR also increases the default restart timeout from 10s to 30s to make it more generous.

(cherry picked from commit eaee2db)
NamanJain8 added a commit that referenced this pull request Sep 21, 2021
There is a logical race condition that causes panic. This happens because the node process did not complete its initialization before being killed. This PR fixes that issue.

This PR also increases the default restart timeout from 10s to 30s to make it more generous.

(cherry picked from commit eaee2db)
NamanJain8 added a commit that referenced this pull request Sep 21, 2021
…8044)

There is a logical race condition that causes panic. This happens because the node process did not complete its initialization before being killed. This PR fixes that issue.

This PR also increases the default restart timeout from 10s to 30s to make it more generous.

(cherry picked from commit eaee2db)
NamanJain8 added a commit that referenced this pull request Sep 21, 2021
…8045)

There is a logical race condition that causes panic. This happens because the node process did not complete its initialization before being killed. This PR fixes that issue.

This PR also increases the default restart timeout from 10s to 30s to make it more generous.

(cherry picked from commit eaee2db)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants