Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(magicNumber): Introduce magic number #8032

Merged
merged 5 commits into from
Sep 16, 2021
Merged

Conversation

ahsanbarkati
Copy link
Contributor

@ahsanbarkati ahsanbarkati commented Sep 16, 2021

Magic number is a unique identifier for the version of Dgraph. In 21.09 we
have changed the data format of posting lists by bringing in sroar. Running
Dgraph with sroar change on older p directory can cause data corruption.
This magic number prevents DB to start up if the version is not compatible.


This change is Reviewable

worker/config.go Outdated Show resolved Hide resolved
Copy link
Contributor

@NamanJain8 NamanJain8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

worker/config.go Outdated Show resolved Hide resolved
@ahsanbarkati ahsanbarkati merged commit 59f6e7a into master Sep 16, 2021
@ahsanbarkati ahsanbarkati deleted the ahsan/magic-number1 branch September 16, 2021 10:26
ahsanbarkati added a commit that referenced this pull request Sep 16, 2021
Magic number is a unique identifier for the data format of dgraph. In 21.09 we
have changed the data format of posting lists by bringing in sroar. Running
Dgraph with sroar change on older p directory can cause data corruption.
This magic number prevents DB to start up if the version is not compatible.

(cherry picked from commit 59f6e7a)
ahsanbarkati added a commit that referenced this pull request Sep 16, 2021
Magic number is a unique identifier for the data format of dgraph. In 21.09 we
have changed the data format of posting lists by bringing in sroar. Running
Dgraph with sroar change on older p directory can cause data corruption.
This magic number prevents DB to start up if the version is not compatible.

(cherry picked from commit 59f6e7a)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants