fix(lambda): shutdown node processes when alpha gets killed #8027
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aman-bansal
approved these changes
Sep 15, 2021
NamanJain8
added a commit
that referenced
this pull request
Sep 16, 2021
We were already handling the graceful shutdown of node processes when alpha shuts down. We were passing the closer.Ctx() so that node process shuts down when alpha stops. But that is not sufficient when alpha panics. In case alpha panics, the alpha gets stuck because the node processes. This happens when sentry is also enabled. Sentry waits for all processes (child as well as grandchild to complete). (cherry picked from commit d3285b8)
NamanJain8
added a commit
that referenced
this pull request
Sep 16, 2021
…8030) We were already handling the graceful shutdown of node processes when alpha shuts down. We were passing the closer.Ctx() so that node process shuts down when alpha stops. But that is not sufficient when alpha panics. In case alpha panics, the alpha gets stuck because the node processes. This happens when sentry is also enabled. Sentry waits for all processes (child as well as grandchild to complete). (cherry picked from commit d3285b8)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were already handling the graceful shutdown of node processes when alpha shuts down.
In case alpha panics, the alpha gets stuck because the node processes.
We were passing the
closer.Ctx()so that node process shuts down when alpha stops. But that is not sufficient when alpha panics.This change is