Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(graphql): fix type assertion failure in graphql if resolver is not defined #8003

Merged
merged 5 commits into from
Aug 27, 2021
Merged

fix(graphql): fix type assertion failure in graphql if resolver is not defined #8003

merged 5 commits into from
Aug 27, 2021

Conversation

NamanJain8
Copy link
Contributor

@NamanJain8 NamanJain8 commented Aug 27, 2021 •
edited
Loading

  • We were not checking the result of type assertion in lambda mutation's response. This causes the GraphQL server to trap a panic. Instead, it should have returned an empty response for unresolved field.
  • Also, it stringifies the logs from the lambda server.
  • Some minor deduplication in the posting list code.

This change is Reviewable

@github-actions github-actions bot added the area/graphql Issues related to GraphQL support on Dgraph. label Aug 27, 2021
ahsanbarkati
ahsanbarkati approved these changes Aug 27, 2021
View reviewed changes
posting/lists.go Outdated Show resolved Hide resolved
@NamanJain8 NamanJain8 merged commit 652ebe3 into master Aug 27, 2021
@NamanJain8 NamanJain8 deleted the naman/cleanup branch August 27, 2021 10:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahsanbarkati ahsanbarkati ahsanbarkati approved these changes

@manishrjain manishrjain Awaiting requested review from manishrjain

Assignees
No one assigned
Labels
area/graphql Issues related to GraphQL support on Dgraph.
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@NamanJain8 @ahsanbarkati