Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(pool): use write lock when getting health info (#7963) #7967

Merged
merged 1 commit into from
Jul 29, 2021
Merged

fix(pool): use write lock when getting health info (#7963) #7967

merged 1 commit into from
Jul 29, 2021

Conversation

NamanJain8
Copy link
Contributor

@NamanJain8 NamanJain8 commented Jul 29, 2021 •
edited by manishrjain
Loading

Fixes: https://discuss.dgraph.io/t/bug-mutex-lock-while-health-checking/14940

There was a race condition when accessing HealthInfo. This PR fixes that.
(cherry picked from commit b41ff1f)

This change is Reviewable

@NamanJain8 NamanJain8 requested a review from manishrjain as a code owner July 29, 2021 12:47
@NamanJain8 NamanJain8 merged commit b77c203 into release/v21.03 Jul 29, 2021
@NamanJain8 NamanJain8 deleted the naman/cp/2103-pool_race branch July 29, 2021 18:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahsanbarkati ahsanbarkati ahsanbarkati approved these changes

@manishrjain manishrjain Awaiting requested review from manishrjain

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@NamanJain8 @ahsanbarkati