fix(rollups): Write rollup keys at ts+1 #7957
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahsanbarkati
changed the title
NamanJain8
approved these changes
Jul 23, 2021
There was a problem hiding this comment.
Reviewable status: 0 of 3 files reviewed, all discussions resolved (waiting on @manishrjain)
ahsanbarkati
added a commit
that referenced
this pull request
Jul 27, 2021
Write rolled up keys at (max ts of the deltas + 1) because if we write the rolled-up keys at the same ts as that of the delta, then in case of WAL replay the rolled-up key would get over-written by the delta which can bring DB to an invalid state.
ahsanbarkati
added a commit
that referenced
this pull request
Jul 27, 2021
Write rolled up keys at (max ts of the deltas + 1) because if we write the rolled-up keys at the same ts as that of the delta, then in case of WAL replay the rolled-up key would get over-written by the delta which can bring DB to an invalid state.
ahsanbarkati
added a commit
that referenced
this pull request
Sep 3, 2021
Write rolled up keys at (max ts of the deltas + 1) because if we write the rolled-up keys at the same ts as that of the delta, then in case of WAL replay the rolled-up key would get over-written by the delta which can bring DB to an invalid state. (cherry picked from commit 3831b49)
danielmai
pushed a commit
that referenced
this pull request
Sep 3, 2021
Write rolled up keys at (max ts of the deltas + 1) because if we write the rolled-up keys at the same ts as that of the delta, then in case of WAL replay the rolled-up key would get over-written by the delta which can bring DB to an invalid state. (cherry picked from commit 3831b49) (cherry picked from commit 4b6b97d)
joshua-goldstein
pushed a commit
that referenced
this pull request
Nov 28, 2022
Write rolled up keys at (max ts of the deltas + 1) because if we write the rolled-up keys at the same ts as that of the delta, then in case of WAL replay the rolled-up key would get over-written by the delta which can bring DB to an invalid state. (cherry picked from commit 3831b49)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We should write rolled up keys at (maxTs of the deltas + 1) because if we write the rolled up keys at the same ts as
that of the delta, then in case of WAL replay the rolled-up key would get over-written by the
delta which can bring DB to an invalid state.
This change is