fix(multi-tenancy): check existence before banning namespace #7887
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahsanbarkati
requested review from
manishrjain and
vvbalaji-dgraph
as code owners
NamanJain8
previously approved these changes
Jun 4, 2021
|
|
mangalaman93
force-pushed
the
ahsan/check-deleteNS
branch
from
bd57d48 to
0a9c5ca
Compare
mangalaman93
requested review from
akon-dey,
skrdgraph,
darkn3rd,
meghalims,
matthewmcneely and
billprovince
as code owners
mangalaman93
force-pushed
the
ahsan/check-deleteNS
branch
from
0a9c5ca to
21a643c
Compare
mangalaman93
requested review from
harshil-goel
and removed request for
manishrjain and
vvbalaji-dgraph
mangalaman93
force-pushed
the
ahsan/check-deleteNS
branch
from
21a643c to
57c26c7
Compare
mangalaman93
changed the title
mangalaman93
force-pushed
the
ahsan/check-deleteNS
branch
from
57c26c7 to
ed5a31b
Compare
Before, the deleting a non-existent namespace would just ban the namespace. This would essentially not allow creating namespaces after this banned namespace. Now, we fail instead of banning a namespace that has not been even created yet.
mangalaman93
force-pushed
the
ahsan/check-deleteNS
branch
from
ed5a31b to
a388f57
Compare
all-seeing-code
approved these changes
May 31, 2023
harshil-goel
approved these changes
May 31, 2023
dgraph-bot
pushed a commit
that referenced
this pull request
Jul 7, 2023
Before, the deleting a non-existent namespace would just ban the namespace. This would essentially not allow creating namespaces after this banned namespace. Now, we fail instead of banning a namespace that has not been even created yet. Co-authored-by: Aman Mangal <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before, the deleting a non-existent namespace would just ban the namespace. This would essentially not allow creating namespaces after this banned namespace. Now, we fail instead of banning a namespace that has not been even created yet.