perf: Speed up parsing of a huge query with a lot of conditional mutations #7871
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
Hey @Phill240 , this looks good. Thanks for it. |
NamanJain8
reviewed
Sep 22, 2021
NamanJain8
reviewed
Sep 23, 2021
|
Thanks, @Phill240 ! 🎉 |
mangalaman93
pushed a commit
that referenced
this pull request
Aug 10, 2023
If a mutation has a lot of conditional mutations, this PR will speed up the parsing of the query. cherry-pick of PR (#7871)
mangalaman93
added a commit
that referenced
this pull request
Aug 10, 2023
If a mutation has a lot of conditional mutations, this PR will speed up the parsing of the query. cherry-pick of PR (#7871)
mangalaman93
added a commit
that referenced
this pull request
Aug 16, 2023
If a mutation has a lot of conditional mutations, this PR will speed up the parsing of the query. cherry-pick of PR (#7871)
jbhamra1
pushed a commit
that referenced
this pull request
Aug 17, 2023
If a mutation has a lot of conditional mutations, this PR will speed up the parsing of the query. cherry-pick of PR (#7871)
jbhamra1
pushed a commit
that referenced
this pull request
Aug 17, 2023
If a mutation has a lot of conditional mutations, this PR will speed up the parsing of the query. cherry-pick of PR (#7871)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recently I faced a situation when my queries containing a lot of conditional mutations (+5000) took a long time to process. According to the servers reply the slowest part of the query handling was parsing. For example:
parsing_ns:835833349 processing_ns:157596840 encoding_ns:5105536 assign_timestamp_ns:454011 total_ns:1033841289
So the parsing took several times longer that the processing itself!
The reason of the issue is in the ineffective implementation of buildUpsertQuery method. I suggest using String Builder instead of just simple string concatenation. After these changes the parsing speed increased significantly:
parsing_ns:134053025 processing_ns:114263143 encoding_ns:4992320 assign_timestamp_ns:495987 total_ns:286159717
This change is