opt(snapshot): use full table copy when streaming the entire data #7870
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jarifibrahim
approved these changes
May 28, 2021
There was a problem hiding this comment.
@NamanJain8 Please do a local snapshot transfer test before merging this PR.
|
@jarifibrahim Verified this locally with encrypted/unencrypted DB of 1M dataset. It works fine. |
mangalaman93
pushed a commit
that referenced
this pull request
Mar 7, 2023
) When streaming the entire data in the snapshot (snap.SinceTs=0), we can do an entire table copy instead of iterating over the KVs. This brings about 3x performance improvement, as well as the CPU of the sender, is idle. Refer hypermodeinc/badger#1700 for more details.
mangalaman93
added a commit
that referenced
this pull request
Mar 7, 2023
) When streaming the entire data in the snapshot (snap.SinceTs=0), we can do an entire table copy instead of iterating over the KVs. This brings about 3x performance improvement, as well as the CPU of the sender, is idle. Refer hypermodeinc/badger#1700 for more details.
mangalaman93
added a commit
that referenced
this pull request
Mar 7, 2023
) When streaming the entire data in the snapshot (snap.SinceTs=0), we can do an entire table copy instead of iterating over the KVs. This brings about 3x performance improvement, as well as the CPU of the sender, is idle. Refer hypermodeinc/badger#1700 for more details.
mangalaman93
added a commit
that referenced
this pull request
Mar 15, 2023
) When streaming the entire data in the snapshot (snap.SinceTs=0), we can do an entire table copy instead of iterating over the KVs. This brings about 3x performance improvement, as well as the CPU of the sender, is idle. Refer hypermodeinc/badger#1700 for more details.
mangalaman93
added a commit
that referenced
this pull request
May 17, 2023
) When streaming the entire data in the snapshot (snap.SinceTs=0), we can do an entire table copy instead of iterating over the KVs. This brings about 3x performance improvement, as well as the CPU of the sender, is idle. Refer hypermodeinc/badger#1700 for more details.
mangalaman93
added a commit
that referenced
this pull request
Jun 7, 2023
) When streaming the entire data in the snapshot (snap.SinceTs=0), we can do an entire table copy instead of iterating over the KVs. This brings about 3x performance improvement, as well as the CPU of the sender, is idle. Refer hypermodeinc/badger#1700 for more details.
mangalaman93
added a commit
that referenced
this pull request
Jun 12, 2023
) When streaming the entire data in the snapshot (snap.SinceTs=0), we can do an entire table copy instead of iterating over the KVs. This brings about 3x performance improvement, as well as the CPU of the sender, is idle. Refer hypermodeinc/badger#1700 for more details.
mangalaman93
added a commit
that referenced
this pull request
Jul 19, 2023
) When streaming the entire data in the snapshot (snap.SinceTs=0), we can do an entire table copy instead of iterating over the KVs. This brings about 3x performance improvement, as well as the CPU of the sender, is idle. Refer hypermodeinc/badger#1700 for more details.
mangalaman93
added a commit
that referenced
this pull request
Jul 19, 2023
) When streaming the entire data in the snapshot (snap.SinceTs=0), we can do an entire table copy instead of iterating over the KVs. This brings about 3x performance improvement, as well as the CPU of the sender, is idle. Refer hypermodeinc/badger#1700 for more details.
mangalaman93
added a commit
that referenced
this pull request
Jan 27, 2025
) When streaming the entire data in the snapshot (snap.SinceTs=0), we can do an entire table copy instead of iterating over the KVs. This brings about 3x performance improvement, as well as the CPU of the sender, is idle. Refer hypermodeinc/badger#1700 for more details.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When streaming the entire data in the snapshot (
snap.SinceTs=0), we can do an entire table copy instead of iterating over the KVs. This brings about 3x performance improvement, as well as the CPU of the sender, is idle. Refer hypermodeinc/badger#1700 for more details.This change is