opt(query): Use sroar in pb.List #7864
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahsanbarkati
requested review from
manishrjain and
vvbalaji-dgraph
as code owners
manishrjain
approved these changes
Jun 4, 2021
There was a problem hiding this comment.
Reviewed 7 of 19 files at r1, 16 of 16 files at r3.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @vvbalaji-dgraph)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use roaring bitmaps in pb.List by default. We fall back to using sorted_uids
when we need the list to be ordered. The APIs defined in the codec acts as
an abstraction layer that decides if sorted_uids or bitmap should be used.
sorted_uids are used if it is present, otherwise, the bitmap is used.
This change is