fix(lease): prevent ID lease overflow #7724
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NamanJain8
requested review from
manishrjain and
vvbalaji-dgraph
as code owners
NamanJain8
force-pushed
the
naman/uid-overflow
branch
from
e484508 to
8edd95d
Compare
NamanJain8
force-pushed
the
naman/uid-overflow
branch
from
8edd95d to
385835d
Compare
jarifibrahim
approved these changes
Apr 15, 2021
NamanJain8
added a commit
that referenced
this pull request
May 11, 2021
(cherry picked from commit d4c6b7c)
NamanJain8
added a commit
that referenced
this pull request
May 11, 2021
(cherry picked from commit d4c6b7c)
NamanJain8
added a commit
that referenced
this pull request
May 11, 2021
* fix(lease): prevent ID lease overflow (#7724) (cherry picked from commit d4c6b7c) * fix(live): make live loader progress on a cluster with very high maxUid (#7743) This PR fixes the following case: If we have a cluster that cannot lease out new UIDs because it has already leased upto its max limit. Now, we try to live load the data with the given UIDs and the AssignIds complains that the limit has reached. Hence, update the xidmap's maxSeenUid and make progress. (cherry picked from commit ad64c01)
ahsanbarkati
pushed a commit
that referenced
this pull request
May 27, 2021
* fix(lease): prevent ID lease overflow (#7724) (cherry picked from commit d4c6b7c) * fix(live): make live loader progress on a cluster with very high maxUid (#7743) This PR fixes the following case: If we have a cluster that cannot lease out new UIDs because it has already leased upto its max limit. Now, we try to live load the data with the given UIDs and the AssignIds complains that the limit has reached. Hence, update the xidmap's maxSeenUid and make progress. (cherry picked from commit ad64c01) (cherry picked from commit 1235438)
ahsanbarkati
pushed a commit
that referenced
this pull request
May 27, 2021
* fix(lease): prevent ID lease overflow (#7724) (cherry picked from commit d4c6b7c) * fix(live): make live loader progress on a cluster with very high maxUid (#7743) This PR fixes the following case: If we have a cluster that cannot lease out new UIDs because it has already leased upto its max limit. Now, we try to live load the data with the given UIDs and the AssignIds complains that the limit has reached. Hence, update the xidmap's maxSeenUid and make progress. (cherry picked from commit ad64c01) (cherry picked from commit 1235438)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes DGRAPH-3262
This PR adds checks to prevent integer overflow in ID lease.
This change is