feat(GRAPHQL): Add language tag support in GraphQL

graphql/e2e/common/common.go

@@ -836,7 +836,7 @@ func RunAll(t *testing.T) {
 	t.Run("query id directive with int", idDirectiveWithInt)
 	t.Run("query id directive with int64", idDirectiveWithInt64)
 	t.Run("query filter ID values coercion to List", queryFilterWithIDInputCoercion)
-
+	t.Run("query multiple language Fields", queryMultipleLangFields)
 	// mutation tests
 	t.Run("add mutation", addMutation)
 	t.Run("update mutation by ids", updateMutationByIds)
@@ -894,6 +894,7 @@ func RunAll(t *testing.T) {
 	t.Run("input coercion to list", inputCoerciontoList)
 	t.Run("multiple external Id's tests", multipleXidsTests)
 	t.Run("Upsert Mutation Tests", upsertMutationTests)
+	t.Run("Update language tag fields", updateLangTagFields)
 
 	// error tests
 	t.Run("graphql completion on", graphQLCompletionOn)

graphql/e2e/common/mutation.go

@@ -6018,3 +6018,67 @@ func upsertMutationTests(t *testing.T) {
 	filter = GetXidFilter("xcode", []interface{}{"S1", "S10"})
 	deleteState(t, filter, 2, nil)
 }
+
+func updateLangTagFields(t *testing.T) {
+	addPersonParams := &GraphQLParams{
+		Query: `
+		mutation addPerson($person: [AddPersonInput!]!) {
+          addPerson(input: $person) {
+            numUids
+          }
+        }`,
+	}
+	addPersonParams.Variables = map[string]interface{}{"person": []interface{}{
+		map[string]interface{}{
+			"name":   "Juliet",
+			"nameHi": "जूलियट",
+			"nameZh": "朱丽叶",
+		},
+	},
+	}
+	gqlResponse := addPersonParams.ExecuteAsPost(t, GraphqlURL)
+	RequireNoGQLErrors(t, gqlResponse)
+	// update Person using language tag field
+	updatePersonParams := &GraphQLParams{
+		Query: `
+		mutation updatePerson {
+           updatePerson(
+             input: {
+               filter: { nameHi: { eq: "जूलियट" } }
+               set: { nameHi: "जूली", nameZh: "朱丽叶" }
+             }
+           ) {
+             numUids
+           }
+        }`,
+	}
+	gqlResponse = updatePersonParams.ExecuteAsPost(t, GraphqlURL)
+	RequireNoGQLErrors(t, gqlResponse)
+
+	queryPerson := &GraphQLParams{
+		Query: `
+			query {
+              queryPerson(filter: { name: { eq: "Juliet" } }) {
+                name
+                nameZh
+                nameHi
+              }
+           }`,
+	}
+	gqlResponse = queryPerson.ExecuteAsPost(t, GraphqlURL)
+	RequireNoGQLErrors(t, gqlResponse)
+
+	queryPersonExpected := `
+	  {
+        "queryPerson": [
+            {
+                "name": "Juliet",
+                "nameZh": "朱丽叶",
+                "nameHi": "जूली"
+            }
+        ]
+      }`
+
+	testutil.CompareJSON(t, queryPersonExpected, string(gqlResponse.Data))
+	DeleteGqlType(t, "Person", map[string]interface{}{}, 1, nil)
+}

graphql/e2e/common/query.go

@@ -3913,3 +3913,150 @@ func idDirectiveWithInt(t *testing.T) {
 	}`
 	require.JSONEq(t, expected, string(response.Data))
 }
+
+func queryMultipleLangFields(t *testing.T) {
+	addPersonParams := &GraphQLParams{
+		Query: `
+		mutation addPerson($person: [AddPersonInput!]!) {
+	       addPerson(input: $person) {
+             numUids
+	       }
+        }`,
+	}
+	//add three Persons
+	addPersonParams.Variables = map[string]interface{}{"person": []interface{}{
+		map[string]interface{}{
+			"name": "Bob",
+		}}}
+
+	gqlResponse := addPersonParams.ExecuteAsPost(t, GraphqlURL)
+	RequireNoGQLErrors(t, gqlResponse)
+
+	addPersonParams.Variables = map[string]interface{}{"person": []interface{}{
+		map[string]interface{}{
+			"name":   "Alice",
+			"nameZh": "爱丽丝",
+		}}}
+
+	gqlResponse = addPersonParams.ExecuteAsPost(t, GraphqlURL)
+	RequireNoGQLErrors(t, gqlResponse)
+
+	addPersonParams.Variables = map[string]interface{}{"person": []interface{}{
+		map[string]interface{}{
+			"name":         "Juliet",
+			"nameHi":       "जूलियट",
+			"nameZh":       "朱丽叶",
+			"professionEn": "singer",
+		},
+	},
+	}
+	gqlResponse = addPersonParams.ExecuteAsPost(t, GraphqlURL)
+	RequireNoGQLErrors(t, gqlResponse)
+
+	queryPerson := &GraphQLParams{
+		Query: `
+			query {
+	            queryPerson(filter:{name:{eq:"Bob"}}) {
+	            	name
+	            	nameZh
+	            	nameHi
+	            	nameHiZh
+                    nameZhHi
+	            	nameHi_Zh_Untag
+	            	name_Untag_AnyLang
+	            }
+        }`,
+	}
+	gqlResponse = queryPerson.ExecuteAsPost(t, GraphqlURL)
+	RequireNoGQLErrors(t, gqlResponse)
+	// Only untag field is present
+	queryPersonExpected := `
+	  {
+        "queryPerson": [
+            {
+                "name": "Bob",
+                "nameZh": null,
+                "nameHi": null,
+                "nameHiZh": null,
+                "nameZhHi": null,
+                "nameHi_Zh_Untag": "Bob",
+                "name_Untag_AnyLang": "Bob"
+            }
+        ]
+      }`
+
+	testutil.CompareJSON(t, queryPersonExpected, string(gqlResponse.Data))
+
+	queryPerson = &GraphQLParams{
+		Query: `
+			query {
+	            queryPerson(filter:{name:{eq:"Alice"}}) {
+	            	name
+	            	nameZh
+	            	nameHi
+	            	nameHiZh
+                    nameZhHi
+	            	nameHi_Zh_Untag
+	            	name_Untag_AnyLang
+	            }
+        }`,
+	}
+	gqlResponse = queryPerson.ExecuteAsPost(t, GraphqlURL)
+	RequireNoGQLErrors(t, gqlResponse)
+	// untagged and chinese name is present
+	queryPersonExpected = `
+	  {
+        "queryPerson": [
+            {
+                "name": "Alice",
+                "nameZh": "爱丽丝",
+                "nameHi": null,
+                "nameHiZh": "爱丽丝",
+                "nameZhHi": "爱丽丝",
+                "nameHi_Zh_Untag": "爱丽丝",
+                "name_Untag_AnyLang": "Alice"
+            }
+        ]
+      }`
+
+	testutil.CompareJSON(t, queryPersonExpected, string(gqlResponse.Data))
+	// untagged and all languages are present
+	// also filter and order by on language tag
+	// also using professionEn lang tagged field for which no untagged lang field is present
+	queryPerson = &GraphQLParams{
+		Query: `
+			query {
+	            queryPerson(filter:{or:[{name:{eq:"Julliet"}},{nameHi:{eq:"जूलियट"}},{nameZh:{eq:"朱丽叶"}},
+                {name_Untag_AnyLang:{eq:"Juliet"}}]}, order: { asc: nameHi }) {
+	            	name
+	            	nameZh
+	            	nameHi
+	            	nameHiZh
+                    nameZhHi
+	            	nameHi_Zh_Untag
+	            	name_Untag_AnyLang
+                    professionEn
+	            }
+        }`,
+	}
+	gqlResponse = queryPerson.ExecuteAsPost(t, GraphqlURL)
+	RequireNoGQLErrors(t, gqlResponse)
+	queryPersonExpected = `
+	  {
+        "queryPerson": [
+            {
+                "name": "Juliet",
+                "nameZh": "朱丽叶",
+                "nameHi": "जूलियट",
+                "nameHiZh": "जूलियट",
+                "nameZhHi": "朱丽叶",
+                "nameHi_Zh_Untag": "जूलियट",
+                "name_Untag_AnyLang": "Juliet",
+                "professionEn": "singer"
+            }
+        ]
+      }`
+	testutil.CompareJSON(t, queryPersonExpected, string(gqlResponse.Data))
+	// Cleanup
+	DeleteGqlType(t, "Person", map[string]interface{}{}, 3, nil)
+}

graphql/e2e/directives/schema.graphql

@@ -210,6 +210,18 @@ type Person1 {
     friends: [Person1] @hasInverse(field: friends)
 }
 
+type Person {
+    id: ID!
+    name: String! @search(by: [hash])
+    nameHi: String @dgraph(pred:"Person.name@hi") @search(by: [hash])
+    nameZh: String @dgraph(pred:"Person.name@zh") @search(by: [hash])
+    nameHiZh: String @dgraph(pred:"Person.name@hi:zh") @search(by: [hash])
+    nameZhHi: String @dgraph(pred:"Person.name@zh:hi") @search(by: [hash])
+    nameHi_Zh_Untag: String @dgraph(pred:"Person.name@hi:zh:.") @search(by: [hash])
+    name_Untag_AnyLang: String @dgraph(pred:"Person.name@.") @search(by: [hash])
+    professionEn: String @dgraph(pred:"Person.profession@en")
+}
+
 # union testing - start
 enum AnimalCategory {
 	Fish

graphql/e2e/directives/schema_response.json

@@ -94,6 +94,20 @@
       "predicate": "Employer.worker",
       "type": "uid"
     },
+    {
+      "lang": true,
+      "predicate": "Person.profession",
+      "type": "string"
+    },
+    {
+      "index": true,
+      "lang": true,
+      "predicate": "Person.name",
+      "tokenizer": [
+        "hash"
+      ],
+      "type": "string"
+    },
     {
       "predicate": "Book.chapters",
       "type": "uid",
@@ -914,6 +928,17 @@
       ],
       "name": "Home"
     },
+    {
+      "fields": [
+        {
+          "name": "Person.name"
+        },
+        {
+          "name": "Person.profession"
+        }
+      ],
+      "name": "Person"
+    },
     {
       "fields": [
         {

graphql/e2e/normal/schema.graphql

@@ -163,8 +163,15 @@ type Student implements People {
 }
 
 type Person @withSubscription{
-    id: ID!
-    name: String!
+        id: ID!
+        name: String! @search(by: [hash])
+        nameHi: String @dgraph(pred:"Person.name@hi") @search(by: [hash])
+        nameZh: String @dgraph(pred:"Person.name@zh") @search(by: [hash])
+        nameHiZh: String @dgraph(pred:"Person.name@hi:zh") @search(by: [hash])
+        nameZhHi: String @dgraph(pred:"Person.name@zh:hi") @search(by: [hash])
+        nameHi_Zh_Untag: String @dgraph(pred:"Person.name@hi:zh:.") @search(by: [hash])
+        name_Untag_AnyLang: String @dgraph(pred:"Person.name@.") @search(by: [hash])
+        professionEn: String @dgraph(pred:"Person.profession@en")
 }
 
 """

graphql/e2e/normal/schema_response.json

@@ -414,7 +414,17 @@
       "upsert": true
     },
     {
+      "lang": true,
+      "predicate": "Person.profession",
+      "type": "string"
+    },
+    {
+      "index": true,
+      "lang": true,
       "predicate": "Person.name",
+      "tokenizer": [
+        "hash"
+      ],
       "type": "string"
     },
     {
@@ -1102,14 +1112,6 @@
       ],
       "name": "People"
     },
-    {
-      "fields": [
-        {
-          "name": "Person.name"
-        }
-      ],
-      "name": "Person"
-    },
     {
       "fields": [
         {
@@ -1419,6 +1421,17 @@
         }
       ],
       "name": "Employer"
+    },
+    {
+      "fields": [
+        {
+          "name": "Person.name"
+        },
+        {
+          "name": "Person.profession"
+        }
+      ],
+      "name": "Person"
     }
   ]
 }

graphql/resolve/add_mutation_test.yaml

@@ -4520,4 +4520,25 @@
           "Friend1.id":"Main Friend",
           "dgraph.type":["Friend1"],
           "uid":"_:Friend1_1"
-       }
+       }
+
+-
+  name: "Add mutation with language tag fields"
+  gqlmutation: |
+    mutation {
+         addPerson(input: { name: "Alice", nameHi: "ऐलिस",nameZh: "爱丽丝"}) {
+           person {
+             name
+             nameZh
+             nameHi
+           }
+         }
+    }
+  dgmutations:
+    - setjson: |
+        { "Person.name":"Alice",
+          "Person.name@hi":"ऐलिस",
+          "Person.name@zh":"爱丽丝",
+          "dgraph.type": ["Person"],
+          "uid": "_:Person_1"
+        }