fix(postingList): Acquire lock before reading the cached posting list #7632
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The GetNew function may fetch the posting list from the cache. This cached copy of the posting list might be still in use at other places and so we need to acquire a lock on it before we read it.
…tinglist-concurrent
NamanJain8
approved these changes
Mar 30, 2021
NamanJain8
pushed a commit
that referenced
this pull request
Mar 31, 2021
…#7632) The GetNew function may fetch the posting list from the cache. This cached copy of the posting list might be still in use at other places and so we need to acquire a lock on it before we read it. Co-authored-by: NamanJain8 <[email protected]> (cherry picked from commit 3f9effa)
aman-bansal
pushed a commit
that referenced
this pull request
Apr 8, 2021
…#7632) The GetNew function may fetch the posting list from the cache. This cached copy of the posting list might be still in use at other places and so we need to acquire a lock on it before we read it. Co-authored-by: NamanJain8 <[email protected]>
NamanJain8
added a commit
that referenced
this pull request
May 5, 2021
…#7632) (#7671) The GetNew function may fetch the posting list from the cache. This cached copy of the posting list might be still in use at other places and so we need to acquire a lock on it before we read it. Co-authored-by: NamanJain8 <[email protected]> (cherry picked from commit 3f9effa) Co-authored-by: Ibrahim Jarif <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The GetNew function may fetch the posting list from the cache. This
cached copy of the posting list might be still in use at other places
and so we need to acquire a lock on it before we read it.
Fixes DGRAPH-3200
This change is