Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Chore(release): fix for xgo version to use #7620

Merged
merged 1 commit into from
Mar 19, 2021
Merged

Chore(release): fix for xgo version to use #7620

merged 1 commit into from
Mar 19, 2021

Conversation

darkn3rd
Copy link
Contributor

@darkn3rd darkn3rd commented Mar 19, 2021 •
edited by manishrjain
Loading

Fix:

  • xgo docker image for 1.16.x now uses GOVERSION (before it was statically setting this to 1.16.0)

This change is Reviewable

@github-actions github-actions bot added the area/integrations Related to integrations with other projects. label Mar 19, 2021
@darkn3rd darkn3rd requested a review from danielmai March 19, 2021 19:59
danielmai
danielmai approved these changes Mar 19, 2021
View reviewed changes
Copy link
Contributor

@danielmai danielmai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r1.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @manishrjain and @vvbalaji-dgraph)

@darkn3rd darkn3rd merged commit 487f5f1 into master Mar 19, 2021
@darkn3rd darkn3rd deleted the joaquin/release-script-fix branch March 19, 2021 22:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danielmai danielmai danielmai approved these changes

@manishrjain manishrjain Awaiting requested review from manishrjain

@vvbalaji-dgraph vvbalaji-dgraph Awaiting requested review from vvbalaji-dgraph

Assignees
No one assigned
Labels
area/integrations Related to integrations with other projects.
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@darkn3rd @danielmai