Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(flags): use GetString for vault path #7605

Merged
merged 1 commit into from
Mar 18, 2021
Merged

fix(flags): use GetString for vault path #7605

merged 1 commit into from
Mar 18, 2021

Conversation

ajeetdsouza
Copy link
Contributor

@ajeetdsouza ajeetdsouza commented Mar 18, 2021 •
edited by manishrjain
Loading

A recent commit erroneously changed Vault's flagPath from GetString to GetPath. This PR changes it back - Vault paths != UNIX paths.

This change is Reviewable

@github-actions github-actions bot added the area/enterprise Related to proprietary features label Mar 18, 2021
@ajeetdsouza ajeetdsouza merged commit 3d9530a into release/v21.03 Mar 18, 2021
@ajeetdsouza ajeetdsouza deleted the ajeet/vault branch March 18, 2021 05:49
aman-bansal pushed a commit that referenced this pull request Mar 25, 2021
@ajeetdsouza @aman-bansal
Use GetString for vault path (#7605)
0ef503a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jarifibrahim jarifibrahim jarifibrahim approved these changes

@manishrjain manishrjain Awaiting requested review from manishrjain

@vvbalaji-dgraph vvbalaji-dgraph Awaiting requested review from vvbalaji-dgraph

Assignees
No one assigned
Labels
area/enterprise Related to proprietary features
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ajeetdsouza @jarifibrahim