Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(telemetry): fix crash due to telemetry #7575

Merged
merged 1 commit into from
Mar 15, 2021

Conversation

NamanJain8
Copy link
Contributor

@NamanJain8 NamanJain8 commented Mar 15, 2021

We are seeing a crash in zero. This PR fixes this.

panic: runtime error: integer divide by zero
goroutine 194 [running]:
github.com/dgraph-io/dgraph/worker.(*groupi).connToZeroLeader(0x31c07a0, 0x205af60)
	/home/ash/go/src/github.com/dgraph-io/dgraph-release/worker/groups.go:681 +0x452
github.com/dgraph-io/dgraph/worker.(*groupi).askZeroForEE.func1(0xc000136000)
	/home/ash/go/src/github.com/dgraph-io/dgraph-release/worker/groups.go:1100 +0x75
github.com/dgraph-io/dgraph/worker.(*groupi).askZeroForEE(0x31c07a0, 0xc0000e6000)
	/home/ash/go/src/github.com/dgraph-io/dgraph-release/worker/groups.go:1123 +0xa9
github.com/dgraph-io/dgraph/worker.EnterpriseEnabled(0x12e)
	/home/ash/go/src/github.com/dgraph-io/dgraph-release/worker/groups.go:1090 +0x63
github.com/dgraph-io/dgraph/worker.GetEEFeaturesList(0xc00013c230, 0x12e, 0x1a1)
	/home/ash/go/src/github.com/dgraph-io/dgraph-release/worker/groups.go:1061 +0x26
github.com/dgraph-io/dgraph/telemetry.(*Telemetry).Post(0xc00077c5a0, 0x0, 0x0)
	/home/ash/go/src/github.com/dgraph-io/dgraph-release/telemetry/telemetry.go:92 +0x52
github.com/dgraph-io/dgraph/dgraph/cmd/zero.(*Server).periodicallyPostTelemetry(0xc0000f0c80)
	/home/ash/go/src/github.com/dgraph-io/dgraph-release/dgraph/cmd/zero/zero.go:130 +0x2b9
created by github.com/dgraph-io/dgraph/dgraph/cmd/zero.run

This change is Reviewable

@NamanJain8 NamanJain8 merged commit 4cfc011 into release/v21.03 Mar 15, 2021
@NamanJain8 NamanJain8 deleted the naman/fix-telemetry branch March 15, 2021 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants