Fix(GraphQL): Change variable name generation for interface auth rules #7559
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
area/graphql
abhimanyusinghgaur
approved these changes
Mar 15, 2021
vmrajas
force-pushed
the
rajas/GRAPHQL-1095
branch
from
b78e16e to
7266fba
Compare
aman-bansal
pushed a commit
that referenced
this pull request
Mar 16, 2021
#7559) * Change variable name generation for interface auth rules * Add empty line at end of file
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
Currently, while generating variable names for types inherited from interfaces. "1" is added to the type name. This can be problematic. It may happen that two queries get the same name causing DQL error. To prevent this from happening, this PR changes the variable generation logic and uses
varGen.Next. This guarantees that there is no collision between generated variable names.Testing:
No new tests added. Existing yaml and e2e tests to test for regression.
Fixes GRAPHQL-1095
This change is