fix(multi-tenancy): fix live loader for case when namespace does not exist for data #7505
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
area/live-loader
jarifibrahim
reviewed
Mar 3, 2021
jarifibrahim
approved these changes
Mar 4, 2021
aman-bansal
pushed a commit
that referenced
this pull request
Mar 9, 2021
…exist for data (#7505) Earlier, when live-loading data through Guardians of Galaxy, the NQuads make their way to the DB even if the namespace does not exist for them. This might lead to very interesting bugs. Fixed by extracting the namespaces by querying the schema. If we encounter a Nquad or schema for which namespace does not exist, we error out and live loader stops.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes DGRAPH-3075
Earlier, when live-loading data through Guardians of Galaxy, the NQuads make their way to the DB even if the namespace does not exist for them. This might lead to very interesting bugs.
This PR fixes it by extracting the namespaces by querying the schema. If we encounter a Nquad or schema for which namespace does not exist, we error out and live loader stops.
This change is