Fix(GraphQL): Refactor Mutation Rewriter for Add and Update Mutations #7409
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add Existence Queries for Mutation Rewriting * Add tests * Add Error handling to getExistenceQueries * Use new code for AddRewriter * Fix Geo * Fix tests * Fix auth tests * Fix resolve tests * Fix add_mutation_test.yaml * Add bug related tests * Address more comments * Rebase * Final changes
* Fix auth tests * Refactor Update Mutation Rewriting * Fix update tests * Add comments and remove unused code * Address comments * Address more comments
github-actions
bot
added
area/enterprise
pawanrawal
approved these changes
Feb 9, 2021
There was a problem hiding this comment.
Reviewed 23 of 23 files at r1.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @manishrjain)
vmrajas
added a commit
that referenced
this pull request
Feb 9, 2021
…#7409) * Feat(GraphQL): Refactor Mutation Rewriting for AddRewriter (#7257) * Add Existence Queries for Mutation Rewriting * Add tests * Add Error handling to getExistenceQueries * Use new code for AddRewriter * Fix Geo * Fix tests * Fix auth tests * Fix resolve tests * Fix add_mutation_test.yaml * Add bug related tests * Address more comments * Rebase * Final changes * Fix(GraphQL): Refactor Mutation Rewriting for Update Rewriter (#7383) * Fix auth tests * Refactor Update Mutation Rewriting * Fix update tests * Add comments and remove unused code * Address comments * Address more comments * Fix ACL test (cherry picked from commit d080743)
vmrajas
added a commit
that referenced
this pull request
Feb 10, 2021
…#7409) (#7413) * Feat(GraphQL): Refactor Mutation Rewriting for AddRewriter (#7257) * Add Existence Queries for Mutation Rewriting * Add tests * Add Error handling to getExistenceQueries * Use new code for AddRewriter * Fix Geo * Fix tests * Fix auth tests * Fix resolve tests * Fix add_mutation_test.yaml * Add bug related tests * Address more comments * Rebase * Final changes * Fix(GraphQL): Refactor Mutation Rewriting for Update Rewriter (#7383) * Fix auth tests * Refactor Update Mutation Rewriting * Fix update tests * Add comments and remove unused code * Address comments * Address more comments * Fix ACL test (cherry picked from commit d080743)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
Recently, two separate PRs for add and update mutation rewriting refactor were merged to graphql_mutation_refactor branch. This PR is about merging all those changes to maser.
Related PRs:
Benchmarking Results for graphql/resolve/mutation_test.go:3LevelDeep10000
Master branch: (Before refactoring)
pkg: github.com/dgraph-io/dgraph/graphql/resolve
Benchmark3LevelDeep10000-8 1 22271327591 ns/op
PASS
ok github.com/dgraph-io/dgraph/graphql/resolve 22.418s
Current branch: (After refactoring)
pkg: github.com/dgraph-io/dgraph/graphql/resolve
Benchmark3LevelDeep10000-8 26 45202006 ns/op
PASS
ok github.com/dgraph-io/dgraph/graphql/resolve 2.708s
Fixes GRAPHQL-962 and GRAPHQL-872
Also fixes GRAPHQL-623, GRAPHQL-803 .
This change is