fix(GraphQL): Fix panic caused by incorrect input coercion of scalar to list #7405
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
area/graphql
pawanrawal
changed the title
pawanrawal
approved these changes
Feb 12, 2021
There was a problem hiding this comment.
Reviewable status: 0 of 6 files reviewed, 2 unresolved discussions (waiting on @jatindevdg)
graphql/e2e/common/mutation.go, line 4833 at r1 (raw file):
{name: "Coercion of Scalar value at root to list ", query: ` mutation{ addpost1(input:{title:"GraphQL",commentsByMonth:1}){
add spaces and correct formatting
graphql/e2e/common/mutation.go, line 4889 at r1 (raw file):
{ "name": "Jack", "posts":[
fix formatting for response as well
JatinDev543
requested review from
manishrjain and
vvbalaji-dgraph
as code owners
JatinDev543
commented
Feb 12, 2021
There was a problem hiding this comment.
Reviewable status: 0 of 10 files reviewed, 2 unresolved discussions (waiting on @manishrjain, @pawanrawal, and @vvbalaji-dgraph)
graphql/e2e/common/mutation.go, line 4833 at r1 (raw file):
Previously, pawanrawal (Pawan Rawal) wrote…
add spaces and correct formatting
added.
graphql/e2e/common/mutation.go, line 4889 at r1 (raw file):
Previously, pawanrawal (Pawan Rawal) wrote…
fix formatting for response as well
fixed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have moved some of the input coercion code to the library as part of the commit. I have also added tests to verify the fix.
Fixes-GRAPHQl-1006
This change is