fix(GraphQl):This PR fix a panic when we pass a single ID as a integer and expected type is [ID].We now coerce that to type array of string. #7325
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
area/graphql
pawanrawal
approved these changes
Jan 19, 2021
There was a problem hiding this comment.
Reviewed 3 of 3 files at r1.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @jatindevdg)
JatinDev543
changed the title
|
Deploy preview for dgraph-docs ready! Built with commit 6e7f64e |
JatinDev543
added a commit
that referenced
this pull request
Jan 22, 2021
…r and expected type is [ID].We now coerce that to type array of string. (#7325) The following query was giving panic because here we passed ID as an int which is expected to be a string. query allStories { queryUser(filter: { id: 22 }) { stories { id text } } } We now added input coercion so that the ID type value will be coerced to string type. And if we give a slice of integer values to ID type variable then that will be coerced to slice of integer values. (cherry picked from commit 5fa6796)
JatinDev543
added a commit
that referenced
this pull request
Jan 22, 2021
…r and expected type is [ID].We now coerce that to type array of string. (#7325) (#7353) The following query was giving panic because here we passed ID as an int which is expected to be a string. query allStories { queryUser(filter: { id: 22 }) { stories { id text } } } We now added input coercion so that the ID type value will be coerced to string type. And if we give a slice of integer values to ID type variable then that will be coerced to slice of integer values. (cherry picked from commit 5fa6796)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The following query was giving panic because here we passed ID as an int which is expected to be a string.
We now added input coercion so that the ID type value will be coerced to string type. And if we give a slice of integer values
to ID type variable then that will be coerced to slice of integer values.
This change is