Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(restore): Handle MaxUid=0 appropriately #7258

Merged
merged 1 commit into from
Jan 8, 2021
Merged

fix(restore): Handle MaxUid=0 appropriately #7258

merged 1 commit into from
Jan 8, 2021

Conversation

jarifibrahim
Copy link
Contributor

@jarifibrahim jarifibrahim commented Jan 7, 2021 •
edited by manishrjain
Loading

At the end of the restore operation, we update the MaxUid in zero. This
MaxUid can be zero if the backup was created from an empty DB.

Fixes DGRAPH-2804

This change is Reviewable

fix(restore): Handle MaxUid=0 appropriately
6a1f285 
At the end of the restore operation we update the MaxUid in zero. This
MaxUid can be zero if the backup was created from an empty DB.
@github-actions github-actions bot added the area/enterprise Related to proprietary features label Jan 7, 2021
NamanJain8
NamanJain8 approved these changes Jan 8, 2021
View reviewed changes
Copy link
Contributor

@NamanJain8 NamanJain8 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's a harmless good to have change. LGTM

@jarifibrahim jarifibrahim merged commit b05fb93 into master Jan 8, 2021
@jarifibrahim jarifibrahim deleted the ibrahim/restore-uid branch January 8, 2021 14:08
jarifibrahim pushed a commit that referenced this pull request Jan 8, 2021
fix(restore): Handle MaxUid=0 appropriately (#7258)
5ab0489 
At the end of the restore operation we update the MaxUid in zero. This
MaxUid can be zero if the backup was created from an empty DB.

(cherry picked from commit b05fb93)
jarifibrahim pushed a commit that referenced this pull request Jan 11, 2021
fix(restore): Handle MaxUid=0 appropriately (#7258) (#7265)
764ac49 
At the end of the restore operation we update the MaxUid in zero. This
MaxUid can be zero if the backup was created from an empty DB.

(cherry picked from commit b05fb93)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NamanJain8 NamanJain8 NamanJain8 approved these changes

@manishrjain manishrjain Awaiting requested review from manishrjain

@vvbalaji-dgraph vvbalaji-dgraph Awaiting requested review from vvbalaji-dgraph

Assignees
No one assigned
Labels
area/enterprise Related to proprietary features
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jarifibrahim @NamanJain8